[
https://issues.apache.org/jira/browse/CALCITE-6626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889434#comment-17889434
]
Julian Hyde commented on CALCITE-6626:
--------------------------------------
Agreed.
It would be useful to make a first pass, and identify any functionality used by
{{SqlToRelConverter}} that is not present in {{{}RelBuilder{}}}. Can you do
that?
> SqlToRelConverter mixes uses of configured RelBuilder and Logical.create
> methods.
> ---------------------------------------------------------------------------------
>
> Key: CALCITE-6626
> URL: https://issues.apache.org/jira/browse/CALCITE-6626
> Project: Calcite
> Issue Type: Bug
> Reporter: Ian Bertolacci
> Priority: Major
>
> SqlToRelConverter takes a configuration which allows setting a
> RelBuilderFactory, which it does use in some places, but in others it
> directly calls LogicalWhatever.create to build a node.
> All RelNode builder calls should (as much as possible) build nodes using the
> configured RelBuilder.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
