[ 
https://issues.apache.org/jira/browse/CALCITE-6626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Hyde resolved CALCITE-6626.
----------------------------------
    Resolution: Duplicate

I thought it sounded familiar. Thanks for digging it up, [~zabetak]!

I put quite a lot of work into 4262 and posted a dev branch. If someone is 
willing to push the work to completion (or just a stopping point that is an 
improvement), I would be happy to rebase my dev branch so they can use that as 
a starting point.

I'm going to close this case. Let's continue discussion on the other case.

> SqlToRelConverter mixes uses of configured RelBuilder and Logical.create 
> methods.
> ---------------------------------------------------------------------------------
>
>                 Key: CALCITE-6626
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6626
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Ian Bertolacci
>            Priority: Major
>
> SqlToRelConverter takes a configuration which allows setting a 
> RelBuilderFactory, which it does use in some places, but in others it 
> directly calls LogicalWhatever.create to build a node.
> All RelNode builder calls should (as much as possible) build nodes using the 
> configured RelBuilder.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to