[ 
https://issues.apache.org/jira/browse/CALCITE-6676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896012#comment-17896012
 ] 

Stamatis Zampetakis commented on CALCITE-6676:
----------------------------------------------

This is a regression that was introduced in 1.38.0 release by the following 
commit:
https://github.com/apache/calcite/commit/9985b6af156d41fc4a986a9aadbf7f8227981388

{noformat}
Refactor: Migrate from assertEquals to assertThat
{noformat}


> DiffRepository does not update log (_actual) file when assertion fails
> ----------------------------------------------------------------------
>
>                 Key: CALCITE-6676
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6676
>             Project: Calcite
>          Issue Type: Bug
>          Components: testkit
>    Affects Versions: 1.38.0
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>             Fix For: 1.39.0
>
>
> Under normal circumstances when a test based on {{DiffRepository}} fails a 
> log file ( with the {{_actual.xml}} suffix) is generated and contains the 
> actual content from the test execution. 
> This {{DiffRepository}} feature is used to update the golden  files easily by 
> copying the log file to the respective file in resources.
> Test fixtures such as {{RelOptFixture}} and {{SqlToRelFixture}} that rely 
> upon {{DiffRepository}} are affected along with all tests using these.
> {{DiffRepository}} and fixtures are published as part of the testkit module 
> so consumers who are using the respective classes are now broken.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to