[
https://issues.apache.org/jira/browse/CALCITE-6676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mihai Budiu resolved CALCITE-6676.
----------------------------------
Resolution: Fixed
Fixed in
https://github.com/apache/calcite/commit/caacc9f95bc583db05f44b53d27d5083ef3a371a
Thank you for the bug report and fix [~zabetak], and thank you to the many
reviewers
> DiffRepository does not update log (_actual) file when assertion fails
> ----------------------------------------------------------------------
>
> Key: CALCITE-6676
> URL: https://issues.apache.org/jira/browse/CALCITE-6676
> Project: Calcite
> Issue Type: Bug
> Components: testkit
> Affects Versions: 1.38.0
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.39.0
>
>
> Under normal circumstances when a test based on {{DiffRepository}} fails a
> log file ( with the {{_actual.xml}} suffix) is generated and contains the
> actual content from the test execution.
> This {{DiffRepository}} feature is used to update the golden files easily by
> copying the log file to the respective file in resources.
> Test fixtures such as {{RelOptFixture}} and {{SqlToRelFixture}} that rely
> upon {{DiffRepository}} are affected along with all tests using these.
> {{DiffRepository}} and fixtures are published as part of the testkit module
> so consumers who are using the respective classes are now broken.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
