[
https://issues.apache.org/jira/browse/CALCITE-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896745#comment-17896745
]
Mihai Budiu commented on CALCITE-6680:
--------------------------------------
Your PR looks fine too. I may add it as a commit against my PR.
But normally one should write tests for each of these cases, which is a lot of
work.
The easiest would be to actually create Quidem tests.
> RexImpTable erroneously declares NullPolicy.NONE for IS_EMPTY
> -------------------------------------------------------------
>
> Key: CALCITE-6680
> URL: https://issues.apache.org/jira/browse/CALCITE-6680
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Chris Dennis
> Assignee: Mihai Budiu
> Priority: Major
> Labels: pull-request-available
> Attachments: is-empty-nullable.patch
>
>
> RexImpTable implements {{IS EMPTY}} and {{IS NOT EMPTY}} using
> {{Collections.isEmpty()}} but declares them as {{NullPolicy.NONE}}. This
> causes nullable array and map columns to throw NPE at execution time when
> hitting null values. I strongly suspect that other collection operators are
> similarly misclassified and would run in to issues is used against nullable
> types.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
