[ 
https://issues.apache.org/jira/browse/CALCITE-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904656#comment-17904656
 ] 

ZheHu edited comment on CALCITE-6146 at 12/11/24 12:36 AM:
-----------------------------------------------------------

Fixed in 
[4948817|[https://github.com/apache/calcite/commit/49488178183cb8c0089b02afde07b6cc6eb8348d]].
Thanks for the review [~mbudiu]


was (Author: vae):
Fixed in 
[4948817](https://github.com/apache/calcite/commit/49488178183cb8c0089b02afde07b6cc6eb8348d).
Thanks for the review [~mbudiu]

> Target charset should be used when comparing two strings through 
> CONVERT/TRANSLATE function during validation
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-6146
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6146
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.36.0
>            Reporter: ZheHu
>            Assignee: ZheHu
>            Priority: Major
>              Labels: pull-request-available
>
> The following test in JdbcTest throws "Cannot apply = to the two different 
> charsets ISO-8859-1 and GBK"
> {code:java}
> CalciteAssert.hr()
>         .query("select \"name\", \"empid\" from \"hr\".\"emps\"\n"
>             + "where convert('a' using GBK)=_GBK'a' order by \"empid\"")
>         .returns("name=Eric; empid=200\n"
>             + "name=Sebastian; empid=150\n"
>             + "name=Theodore; empid=110\n"
>             + "name=Bill; empid=100\n");
> {code}
> Since we try to convert 'a' with GBK, the charset of its result should also 
> be treated as GBK.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to