[ 
https://issues.apache.org/jira/browse/CALCITE-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924567#comment-17924567
 ] 

Ruben Q L commented on CALCITE-6817:
------------------------------------

Honestly this change, even if simple, seem rather disruptive, not only on 
Calcite (test) code, but also for any downstream project having tests/checks on 
the plan level, which would need to adjust the expected plan representations if 
this gets done.

I'd like to see some consensus among the community before moving on with this.

> Add string representation of default nulls direction for RelNode
> ----------------------------------------------------------------
>
>                 Key: CALCITE-6817
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6817
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.38.0
>            Reporter: ZheHu
>            Assignee: ZheHu
>            Priority: Minor
>              Labels: pull-request-available
>
> Calcite has the same hehavior with Oracle on returning the null direction if 
> not specified, which means NULLS LAST is assumed for ASC and NULLS FIRST is 
> assumed for DESC.
> However, the default nulls direction is not presented in plan traces. For 
> example:
> {code:java}
> select empno from emp order by empno desc
> {code}
> has the following plan:
> {code:java}
> LogicalSort(sort0=[$0], dir0=[DESC])
>   LogicalProject(EMPNO=[$0])
>     LogicalTableScan(table=[[CATALOG, SALES, EMP]])
> {code}
> It makes RelNode clearer if adding nulls direction, so the above plan will be 
> like:
> {code:java}
> LogicalSort(sort0=[$0], dir0=[DESC-nulls-first])
>   LogicalProject(EMPNO=[$0])
>     LogicalTableScan(table=[[CATALOG, SALES, EMP]])
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to