[
https://issues.apache.org/jira/browse/CALCITE-6819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925073#comment-17925073
]
Julian Hyde edited comment on CALCITE-6819 at 2/7/25 11:40 PM:
---------------------------------------------------------------
Does MSSQL allow 'TRUE' in other contexts, e.g. {{WHERE TRUE}}, {{HAVING
TRUE}}, {{SELECT TRUE}}?
I saw you moved {{convertConditionToSqlNode}} from {{SqlImplementor}} to
{{RelToSqlConverter}}. I think you should leave it in {{SqlImplementor}}, just
make it non-static.
This is very similar to CALCITE-6482. Could you use the same fix?
was (Author: julianhyde):
Does MSSQL allow 'TRUE' in other contexts, e.g. {{WHERE TRUE}}, {{HAVING
TRUE}}, {{SELECT TRUE}}?
I saw you moved {{convertConditionToSqlNode}} from {{SqlImplementor}} to
{{RelToSqlConverter}}. I think you should leave it in {{SqlImplementor}}, just
make it non-static.
> MSSQL doesn't support TRUE/FALSE keywords in its Join predicate
> ---------------------------------------------------------------
>
> Key: CALCITE-6819
> URL: https://issues.apache.org/jira/browse/CALCITE-6819
> Project: Calcite
> Issue Type: Bug
> Reporter: Sree Harsha Ramanavarapu
> Priority: Major
> Labels: pull-request-available
>
> CREATE TABLE t1 (c11 int, c12 int);
> INSERT INTO t1 VALUES (1,10), (2,20), (3,30);
> CREATE TABLE t2 (c21 int, c22 int);
> SELECT * FROM t1 LEFT OUTER JOIN t2 ON TRUE;
> Msg 4145, Level 15, State 1, Server a08c6f7cfc77, Line 9
> An expression of non-boolean type specified in a context where a condition is
> expected, near ';'.
> TRUE/FALSE are not supported in MSSQL (but it is supported in most DBs).
> The MSSQL way would be to write the query as :
> SELECT * FROM t1 LEFT OUTER JOIN t2 ON 1=1;
> MSSQL dialect should support this syntax.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
