[ 
https://issues.apache.org/jira/browse/CALCITE-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929700#comment-17929700
 ] 

Zhen Chen commented on CALCITE-6850:
------------------------------------

 [Alessandro 
Solimando|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=asolimando]

Here we discuss the issue of ProjectRemoveRule. If the project does not 
consider the alias problem, then I think there is no case in CALCITE-6850 that 
can produce the expected result, but that code is indeed problematic.

We can only get this result, regardless of whether the code is modified or not

before:

 
{code:java}
LogicalProject(O=[$0]) 
  LogicalProject(ORI_NAME=[$0]) {code}
after:
{code:java}
LogicalProject(ORI_NAME=[$0]) {code}
I can add a test case like this, but is it necessary? Also, we have found 
errors in this PR at the code level. What kind of example do we want to prove 
what problem?

 

> Fix In ProjectRemoveRule stripped always get HepRelVertex type
> --------------------------------------------------------------
>
>                 Key: CALCITE-6850
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6850
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.39.0
>            Reporter: Zhen Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.39.0
>
>
> The stripped type always is HepRelVertex, Project type will not appear. The 
> logic of determining whether it is a project type will not be used. But it's 
> difficult to construct an example using SQL.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to