[
https://issues.apache.org/jira/browse/CALCITE-6718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932272#comment-17932272
]
suibianwanwan commented on CALCITE-6718:
----------------------------------------
+1, for the things discussed in the PR. I can submit a new ticket in a couple
days and try to fix it. But it's a small enough impact that we don't have to
wait.
> Optimize SubstitutionVisitor's splitFilter with early return and uniform
> simplification for equivalence checking
> ----------------------------------------------------------------------------------------------------------------
>
> Key: CALCITE-6718
> URL: https://issues.apache.org/jira/browse/CALCITE-6718
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.38.0
> Reporter: yanjing.wang
> Assignee: yanjing.wang
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.39.0
>
>
> The {{splitFilter}} function in {{SubstitutionVisitor}} is designed to
> compute compensation predicates for materialized view substitution.
> According to the documentation, if the condition is stronger than the target,
> the function returns the residue. This means that if the target is always
> true, we can return the condition early.
> When checking if {{{}(condition AND target) = condition{}}}, only the first
> argument used simplifyUnknownAsFalse, the second argument used simplify
> actually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
