[
https://issues.apache.org/jira/browse/CALCITE-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935065#comment-17935065
]
xiong duan commented on CALCITE-6888:
-------------------------------------
I think this PR is unnecessary if there are no obvious differences between
Dories and Starrocks.
If you want to add this Doris dialect, perhaps you should extend
StarRocksSqlDialect. Then we don't need so many test cases. In fact, they have
all been covered by Starrocks. We only need to cover the differences that are
clearly distinct.
> Doris dialect implementation
> ----------------------------
>
> Key: CALCITE-6888
> URL: https://issues.apache.org/jira/browse/CALCITE-6888
> Project: Calcite
> Issue Type: Improvement
> Reporter: Zhen Chen
> Assignee: Zhen Chen
> Priority: Major
> Labels: pull-request-available
>
> Do we need this implementation?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
