[
https://issues.apache.org/jira/browse/CALCITE-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936113#comment-17936113
]
Stamatis Zampetakis commented on CALCITE-6895:
----------------------------------------------
I find the test useful and necessary. I am just questioning the wide range of
acceptance which makes it imprecise and confusing for the RM (myself in this
case) when it fails.
In the PR, I propose to simply make the check stricter/exact adding also a
brief mention to the release howto guide. If you don't agree with this proposal
then I can just increase the upper bound by 10 as it was done in the last 3-4
times. Let me know what you prefer I don't feel that strongly about it.
> Change JdbcTest.testVersion to strictly match minor version in
> gradle.properties
> --------------------------------------------------------------------------------
>
> Key: CALCITE-6895
> URL: https://issues.apache.org/jira/browse/CALCITE-6895
> Project: Calcite
> Issue Type: Task
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.40.0
>
>
> A [recent
> bump|https://github.com/apache/calcite/commit/f0195df7fe18b8d99d5e1d259a3e35834e4c77e2]
> of calcite.version to 1.40.0 broke {{JdbcTest.test}} version cause the
> following condition was no longer true.
> {code:java}
> assertTrue(driverMinor >= 0 && driverMinor < 40);
> {code}
> If we want to test that versions in properties really match those in JDBC it
> makes more sense to have strict equality instead of range. The drawback is
> that we have to update the test after every version bump.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
