[ 
https://issues.apache.org/jira/browse/CALCITE-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mihai Budiu resolved CALCITE-6911.
----------------------------------
    Fix Version/s: 1.40.0
       Resolution: Fixed

Fixed in 
https://github.com/apache/calcite/commit/7ac3ac8725e2577e217fdd21bac828d554ee6d7b
Thank you for the reviews [~nobigo][~caicancai]

> SqlItemOperator.inferReturnType throws AssertionError for out of bounds 
> accesses
> --------------------------------------------------------------------------------
>
>                 Key: CALCITE-6911
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6911
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.39.0
>            Reporter: Mihai Budiu
>            Assignee: Mihai Budiu
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.40.0
>
>
> Clearly, AssertionError is the wrong error to report for something that is a 
> normal validation error.
> Example: 
> {code:sql}
> select x[2] from (select ROW(1) as x)
> {code}
> Stack trace:
> {code}
>       at 
> org.apache.calcite.sql.fun.SqlItemOperator.inferReturnType(SqlItemOperator.java:179)
>       at 
> org.apache.calcite.sql.SqlOperator.validateOperands(SqlOperator.java:531)
>       at org.apache.calcite.sql.SqlOperator.deriveType(SqlOperator.java:630)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl$DeriveTypeVisitor.visit(SqlValidatorImpl.java:7092)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl$DeriveTypeVisitor.visit(SqlValidatorImpl.java:7079)
>       at org.apache.calcite.sql.SqlCall.accept(SqlCall.java:168)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.deriveTypeImpl(SqlValidatorImpl.java:2028)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.deriveType(SqlValidatorImpl.java:2015)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.expandSelectItem(SqlValidatorImpl.java:507)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelectList(SqlValidatorImpl.java:5140)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelect(SqlValidatorImpl.java:4134)
>       at 
> org.apache.calcite.sql.validate.SelectNamespace.validateImpl(SelectNamespace.java:62)
>       at 
> org.apache.calcite.sql.validate.AbstractNamespace.validate(AbstractNamespace.java:96)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validateNamespace(SqlValidatorImpl.java:1208)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validateQuery(SqlValidatorImpl.java:1179)
>       at org.apache.calcite.sql.SqlSelect.validate(SqlSelect.java:282)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validateScopedExpression(SqlValidatorImpl.java:1145)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validate(SqlValidatorImpl.java:851)
>       at 
> org.apache.calcite.sql.test.AbstractSqlTester.assertExceptionIsThrown(AbstractSqlTester.java:106)
>       at 
> org.apache.calcite.test.SqlValidatorFixture.fails(SqlValidatorFixture.java:202)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to