[
https://issues.apache.org/jira/browse/CALCITE-7030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953000#comment-17953000
]
xiong duan commented on CALCITE-7030:
-------------------------------------
Fixed in
[1d4b1fd|https://github.com/apache/calcite/commit/1d4b1fd6e9e6953f43ee5c985b3e4aa10ce568e1].
Thanks for the review [~mbudiu].
> Enhance TopologicalOrderIterator to support BOTTOM_UP
> -----------------------------------------------------
>
> Key: CALCITE-7030
> URL: https://issues.apache.org/jira/browse/CALCITE-7030
> Project: Calcite
> Issue Type: Bug
> Reporter: xiong duan
> Assignee: xiong duan
> Priority: Major
> Labels: pull-request-available
>
>
> Currently , if the BOTTOM_UP approach is adopted, it achieved by reversing
> the results of TOP_DOWN.
> {code:java}
> case BOTTOM_UP:
> // TODO jvs 4-Apr-2006: enhance TopologicalOrderIterator
> // to support reverse walk.
> final List<HepRelVertex> list = new ArrayList<>();
> for (HepRelVertex vertex : TopologicalOrderIterator.of(graph)) {
> list.add(vertex);
> }
> Collections.reverse(list);
> return list.iterator(); {code}
> In this PR, TopologicalOrderIterator will support BOTTOM_UP and TOP_DOWN
> mode both.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
