[
https://issues.apache.org/jira/browse/CALCITE-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012202#comment-18012202
]
Julian Hyde edited comment on CALCITE-7119 at 8/5/25 7:10 PM:
--------------------------------------------------------------
It is reasonable to log this Jira case, and reasonable to keep it open.
But you could do a better job as author of the case. Spell the method name
correctly, so that people can find it. Link to the method, so that people can
read it. Research and link to related issues, such as the case(s) that
introduced the method, and document why the function was initially introduced.
Yet again, you have logged a Jira case after you wrote the PR. As I have said
repeatedly, log the Jira case first, and let's discuss the requirements.
Writing code is easy. Writing requirements is hard.
was (Author: julianhyde):
It is reasonable to log this Jira case, and reasonable to keep it open.
But you could do a better job as author of the case. Spell the method name
correctly, so that people can find it. Link to the method, so that people can
read it. Research and link to related issues, such as the case(s) that
introduced the method, and document what was the intent of the
Yet again, you have logged a Jira case after you wrote the PR. As I have said
repeatedly, log the Jira case first, and let's discuss the requirements.
Writing code is easy. Writing requirements is hard.
> The Dialect module does not require the supportFunctions interface
> ------------------------------------------------------------------
>
> Key: CALCITE-7119
> URL: https://issues.apache.org/jira/browse/CALCITE-7119
> Project: Calcite
> Issue Type: Improvement
> Reporter: Yu Xu
> Assignee: Yu Xu
> Priority: Minor
> Labels: pull-request-available
>
> *This is a regular minor-fix issue:*
> The Dialect.supportFunctions interface is not currently called anywhere,
> although it is inherited by some subclasses.
> Currently, only supportFunctions in the Dialect interface has no meaning and
> will affect the judgment of future Calcite developers. Therefore, it may be
> appropriate to delete this interface.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
