[
https://issues.apache.org/jira/browse/CALCITE-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012304#comment-18012304
]
Julian Hyde edited comment on CALCITE-7119 at 8/8/25 1:58 AM:
--------------------------------------------------------------
[~julianhyde] Thanks for the reminder and guidance.I will follow this principle.
Currently, this interface was introduced due to this JIRA: CALCITE-2128.
However, after reviewing the corresponding PR again, I found that this method
still has no effect. Retrieving the supportsFunction is already accomplished in
JethroInfoCacheImpl.get().
Furthermore, the other inherited dialect classes (FireboltSqlDialect,
PostgresqlSqlDialect, and VerticaSqlDialect) do not use the supportsFunction
method at all. Therefore, I think this interface should be removed to avoid
misleading future developers.
was (Author: JIRAUSER307770):
[~julianhyde] Thanks for the reminder and guidance.I will follow this principle.
Currently, this interface was introduced due to this JIRA
https://issues.apache.org/jira/browse/CALCITE-2128.
However, after reviewing the corresponding PR again, I found that this method
still has no effect. Retrieving the supportsFunction is already accomplished in
JethroInfoCacheImpl.get().
Furthermore, the other inherited dialect classes (FireboltSqlDialect,
PostgresqlSqlDialect, and VerticaSqlDialect) do not use the supportsFunction
method at all. Therefore, I think this interface should be removed to avoid
misleading future developers.
> The Dialect module does not require the supportsFunction interface
> ------------------------------------------------------------------
>
> Key: CALCITE-7119
> URL: https://issues.apache.org/jira/browse/CALCITE-7119
> Project: Calcite
> Issue Type: Improvement
> Reporter: Yu Xu
> Assignee: Yu Xu
> Priority: Minor
> Labels: pull-request-available
>
> *This is a regular minor-fix issue:*
> The Dialect.supportsFunction interface is not currently called anywhere,
> although it is inherited by some subclasses.
> Currently, only supportFunctions in the Dialect interface has no meaning and
> will affect the judgment of future Calcite developers. Therefore, it may be
> appropriate to delete this interface.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
