[ 
https://issues.apache.org/jira/browse/CALCITE-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015039#comment-18015039
 ] 

weihua zhang commented on CALCITE-7139:
---------------------------------------

[~julianhyde] Ok, I will change the summary after I come up a way to express my 
thoungt.

[~mbudiu] Hi, how to test following postgresql query in calcite:

{code:sql}
postgres=# select TIMESTAMP WITH TIME ZONE '1969-07-20 20:17:40 Asia/Shanghai';
 1969-07-20 12:17:40+00

postgres=# select TIMESTAMP WITH TIME ZONE '1969-07-20 20:17:40';
 1969-07-20 20:17:40+00
{code}
I think 
https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/sql2rel/SqlNodeToRexConverterImpl.java#L130
and 
https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/sql/parser/SqlParserUtil.java#L407
have some bugs.

> SqlTimestampTzLiteral cannot be cast to class SqlTimestampLiteral
> -----------------------------------------------------------------
>
>                 Key: CALCITE-7139
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7139
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: weihua zhang
>            Priority: Major
>
> I add a new test case in SqlToRelConverterTest.java
> {code:java}
> @Test void testJoinTemporalTableOnSpecificTimestampWithTimeZone() {
>     final String sql = "select stream *\n"
>         + "from orders,\n"
>         + "  products_temporal for system_time as of\n"
>         + "    TIMESTAMP WITH TIME ZONE '2011-01-02 00:00:00 Asia/Shanghai'";
>     sql(sql).ok();
>   }
> {code}
> {code:java}
> class org.apache.calcite.sql.SqlTimestampTzLiteral cannot be cast to class 
> org.apache.calcite.sql.SqlTimestampLiteral 
> (org.apache.calcite.sql.SqlTimestampTzLiteral and 
> org.apache.calcite.sql.SqlTimestampLiteral are in unnamed module of loader 
> 'app')
> java.lang.ClassCastException: class 
> org.apache.calcite.sql.SqlTimestampTzLiteral cannot be cast to class 
> org.apache.calcite.sql.SqlTimestampLiteral 
> (org.apache.calcite.sql.SqlTimestampTzLiteral and 
> org.apache.calcite.sql.SqlTimestampLiteral are in unnamed module of loader 
> 'app')
>       at 
> org.apache.calcite.sql2rel.SqlNodeToRexConverterImpl.convertLiteral(SqlNodeToRexConverterImpl.java:133)
>       at 
> org.apache.calcite.sql2rel.SqlNodeToRexConverterImpl.convertLiteral(SqlNodeToRexConverterImpl.java:162)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:5895)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:5073)
>       at org.apache.calcite.sql.SqlLiteral.accept(SqlLiteral.java:596)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.convertExpression(SqlToRelConverter.java:5724)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertTemporalTable(SqlToRelConverter.java:2969)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertFrom(SqlToRelConverter.java:2476)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertFrom(SqlToRelConverter.java:2359)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertJoin(SqlToRelConverter.java:3274)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertFrom(SqlToRelConverter.java:2480)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertFrom(SqlToRelConverter.java:2359)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertSelectImpl(SqlToRelConverter.java:755)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertSelect(SqlToRelConverter.java:735)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertQueryRecursive(SqlToRelConverter.java:3923)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertQuery(SqlToRelConverter.java:628)
>       at 
> org.apache.calcite.sql.test.AbstractSqlTester.convertSqlToRel2(AbstractSqlTester.java:570)
>       at 
> org.apache.calcite.sql.test.AbstractSqlTester.assertSqlConvertsTo(AbstractSqlTester.java:511)
>       at 
> org.apache.calcite.sql.test.AbstractSqlTester.assertConvertsTo(AbstractSqlTester.java:489)
>       at 
> org.apache.calcite.test.SqlToRelFixture.convertsTo(SqlToRelFixture.java:106)
>       at org.apache.calcite.test.SqlToRelFixture.ok(SqlToRelFixture.java:94)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to