[
https://issues.apache.org/jira/browse/CALCITE-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18034442#comment-18034442
]
Julian Hyde commented on CALCITE-7258:
--------------------------------------
I think this is better, but still rather abstract. "Filter creation" is an
abstract noun. It implies that something is happening but doesn't say who is
doing the thing. Make "RelBuilder" the subject of the sentence.
This is only the headline, so it doesn't capture 100% of the truth. The reader
can infer that filters created by other routes will undergo similar validation.
Once you have a good headline - in the Jira case, in the commit message, in the
release notes - you can describe the details in the body of the commit message.
I you had written “RelBuilder.filter should throw if the condition is not
BOOLEAN” I would not have had to read the PR. That is the goal.
> Filter creation should throw an error if the condition is not of BOOLEAN type
> -----------------------------------------------------------------------------
>
> Key: CALCITE-7258
> URL: https://issues.apache.org/jira/browse/CALCITE-7258
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.40.0
> Reporter: Zhen Chen
> Assignee: Zhen Chen
> Priority: Minor
> Labels: pull-request-available
>
> As discussed in CALCITE-6448, the creation of a Filter in RelBuilder has been
> updated to validate that the condition is of Boolean type. This change aligns
> the logic at the RelNode level with that at the SqlNode level.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
