[ 
https://issues.apache.org/jira/browse/CALCITE-7261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18036178#comment-18036178
 ] 

Sergey Nuyanzin commented on CALCITE-7261:
------------------------------------------

Merged as 
[253ed4639fdc07dd58de3f310503df2847500973|https://github.com/apache/calcite/commit/253ed4639fdc07dd58de3f310503df2847500973]

Thank you for the review [~mbudiu], [~caicancai]

> DiffRepository generation xml doesn't respect alphabetical order
> ----------------------------------------------------------------
>
>                 Key: CALCITE-7261
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7261
>             Project: Calcite
>          Issue Type: Bug
>          Components: testkit
>            Reporter: Sergey Nuyanzin
>            Assignee: Sergey Nuyanzin
>            Priority: Major
>              Labels: pull-request-available
>
> Especially often reproduced for existing empty files.
> For instance current expected is empty or absent (might be a case if just 
> want to regenerate from scratch)
> then if a class has methods
> {code:java}
>   @Test void testDiff() {
>     ...
>   }
>   @Test void testmulti() {
>       ...
>   }
>   @Test void testNull() {
>       ...
>   }
> {code}
> Here {{testmulti}} was intentionally written in lowercase to highlight 
> another issue. While generation it compares names with ignoring case. At the 
> same side while sorting in {{DiffRepository}} it uses lexicographical order 
> without ignoring of case.
> So as a result generated xml for the class with methods above might result in 
> a variety of versions and not stable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to