[ 
https://issues.apache.org/jira/browse/CALCITE-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18048021#comment-18048021
 ] 

Alessandro Solimando commented on CALCITE-7342:
-----------------------------------------------

I agree that there is a maintenance burden and risk of diverging but I am under 
the impression that the community agrees that adopting the new decorrelator is 
worth it, and that's my personal feeling to. And your current approach seems a 
first pragmatic approach to move things forward. Contributors and especially 
reviewers will have to be disciplined to keep the situation manageable, if we 
see that this gets too complicated we can reevaluate our position.

> Quidem test support for TopDownGeneralDecorrelator
> --------------------------------------------------
>
>                 Key: CALCITE-7342
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7342
>             Project: Calcite
>          Issue Type: New Feature
>          Components: core
>    Affects Versions: 1.41.0
>            Reporter: Zhen Chen
>            Assignee: Zhen Chen
>            Priority: Minor
>              Labels: pull-request-available
>
> We recently merged the new TopDownGeneralDecorrelator (CALCITE-7031). 
> Currently, configuration has only been added to RelOptFixture, but end-to-end 
> testing of Calcite cannot be performed using the new Decorrelator. To perform 
> end-to-end testing, we might need a configuration to enable the new 
> Decorrelator (it's disabled by default). This is necessary to advance the 
> further development and validation of the new Decorrelator, such as 
> implementing MARK JOIN in CALCITE-7315 in the future, or assuming the new 
> Decorrelator can truly become a production-ready option for users. All of 
> this requires thorough testing, so this Jira implementation aims to provide a 
> quidem test example that supports the new Decorrelator to support future 
> development. However, this will introduce a configuration parameter to enable 
> the new Decorrelator, which may remain for a considerable period until the 
> new Decorrelator reaches production-ready status.
> The current Jira idea is to provide a dedicated decorrelate.iq file to 
> support continuous iteration.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to