[
https://issues.apache.org/jira/browse/CALCITE-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Solimando updated CALCITE-7351:
------------------------------------------
Description:
CALCITE-6598 introduced _getMaxScale(SqlTypeName)_ and
_getMaxPrecision(SqlTypeName)_ to replace _getMaxNumericScale()_ and
_getMaxNumericPrecision()_, which got deprecated (version 1.38.0).
The ticket suggests that in the next release (1.39.0), the two methods should
have been marked _final_, which didn't happen, having as a side-effect for
projects having a custom type system not fully overriding the
_getMaxScale(SqlTypeName)_ and _getMaxPrecision(SqlTypeName)_ methods, to have
inconsistent behaviors.}}
The ticket implements the suggested change and is a breaking change.
was:
CALCITE-6598 introduced _getMaxScale(SqlTypeName)_ and
_getMaxPrecision(SqlTypeName)_ to replace _getMaxNumericScale() _ and
_getMaxNumericPrecision()_, which got deprecated (version 1.38.0).
The ticket suggests that in the next release (1.39.0), the two methods should
have been marked _final_, which didn't happen, having as a side-effect for
projects having a custom type system not fully overriding the
_getMaxScale(SqlTypeName)_ and _getMaxPrecision(SqlTypeName)_ methods, to have
inconsistent behaviors.}}
The ticket implements the suggested change and is a breaking change.
> Make getMaxNumericScale() and getMaxNumericPrecision() final
> ------------------------------------------------------------
>
> Key: CALCITE-7351
> URL: https://issues.apache.org/jira/browse/CALCITE-7351
> Project: Calcite
> Issue Type: Task
> Components: core
> Affects Versions: 1.41.0
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Minor
> Labels: breaking_change, pull-request-available
> Fix For: 1.42.0
>
>
> CALCITE-6598 introduced _getMaxScale(SqlTypeName)_ and
> _getMaxPrecision(SqlTypeName)_ to replace _getMaxNumericScale()_ and
> _getMaxNumericPrecision()_, which got deprecated (version 1.38.0).
> The ticket suggests that in the next release (1.39.0), the two methods should
> have been marked _final_, which didn't happen, having as a side-effect for
> projects having a custom type system not fully overriding the
> _getMaxScale(SqlTypeName)_ and _getMaxPrecision(SqlTypeName)_ methods, to
> have inconsistent behaviors.}}
> The ticket implements the suggested change and is a breaking change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
