[
https://issues.apache.org/jira/browse/CALCITE-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18052489#comment-18052489
]
Zhen Chen commented on CALCITE-7381:
------------------------------------
[~rubenql] If the previous contributor has used
"!set insubquerythreshold 0", the next contributor who adds test cases to the
current
".iq" file will be affected by this
"insubquerythreshold 0", as the default value of
"insubquerythreshold" is 20. My suggestion is to add either
"!set insubquerythreshold 20" or
"!set insubquerythreshold default" after adding
"!set insubquerythreshold 0" and the test cases. This resets all configurations
to their defaults, similar to how
"!set planner-rules original" is typically used at the end of
"planner.iq".
> Parameters modified by !set must be restored to their default values in
> Quidem test
> ------------------------------------------------------------------------------------
>
> Key: CALCITE-7381
> URL: https://issues.apache.org/jira/browse/CALCITE-7381
> Project: Calcite
> Issue Type: Test
> Components: core
> Reporter: Zhen Chen
> Priority: Major
>
> For example in sub-query.iq
> {code:java}
> !set insubquerythreshold 0
> !set trimfields false{code}
> However, insubquerythreshold was not restored to 20 and trimfields was not
> restored to true.
> Other .iq files also exhibit similar issues. This can affect the correctness
> of subsequent tests to some extent.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
