[ 
https://issues.apache.org/jira/browse/CALCITE-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18053495#comment-18053495
 ] 

Yu Xu commented on CALCITE-7388:
--------------------------------

Fixed in 
[6fab1a1|https://github.com/apache/calcite/commit/6fab1a1b64766ce5a7167b5be3e62505b99fad07]

Thank you for the fix [~terran2010] 

Thank you for the review [~mbudiu] 

> Redis Adapter operand config should not support empty string
> ------------------------------------------------------------
>
>                 Key: CALCITE-7388
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7388
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.41.0
>            Reporter: terran2010
>            Priority: Major
>              Labels: pull-request-available
>
> The normal config
> {code:java}
> "operand": {
>   "dataFormat": "csv",
>   "keyDelimiter": ":",
>   "fields": [
>     {
>       "name": "DEPTNO",
>       "type": "varchar",
>       "mapping": 0
>     },
>     {
>       "name": "NAME",
>       "type": "varchar",
>       "mapping": 1
>     }
>   ]
> } {code}
> but this config
> {code:java}
> "operand": {
>   "dataFormat": "",
>   "keyDelimiter": ":",
>   "fields": []
> } {code}
> It was successfully loaded into the Redis data model, resulting in errors 
> when executing SQL. Normally, illegal key parameters should be disabled when 
> building metadata. We can consider optimizing it



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to