[ 
https://issues.apache.org/jira/browse/CALCITE-5787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18053755#comment-18053755
 ] 

Zhen Chen commented on CALCITE-5787:
------------------------------------

While I will utilize some AI assistance, I want to clarify that this code 
reflects my initial understanding, and therefore, I believe there was a 
misunderstanding on my part. My initial understanding was that I needed to 
retrieve the indices from the inputs; for example, in the join you mentioned, I 
intended to obtain two bitsets, namely \{...} and \{0}, not \{..., 7}. However, 
after confirming with you again and reconfirming the requirements in the 
SemiJoinRule, I realized my misunderstanding. Therefore, I have proposed a 
modification; would you find it acceptable? I believe this issue was indeed 
caused by insufficient communication, and I apologize again.

> The RelMdInputFieldsUsed is introduced to track the usage of input fields
> -------------------------------------------------------------------------
>
>                 Key: CALCITE-5787
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5787
>             Project: Calcite
>          Issue Type: New Feature
>            Reporter: Rong Rong
>            Assignee: Zhen Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.42.0
>
>
> It would be super useful to detect all the input fields used in a {{RelNode}} 
> to indicate what's being used from the inputs. 
> We have a similar utility to find all input fields referenced for a 
> {{RexNode}} via {{RelOptUtil.InputFinder}}. For a relation we can do one step 
> further to automatically keep track of all the relevant relations.
> For example,
>  - {{Aggregate}} relations: {{RelNode.getInputFieldsUsed}} should return a 
> union of the input fields used by {{groupSet}} and all {{aggregateCall}}  
>  - for each {{aggregateCall}}, we should include all fields used in 
> {{{}argList{}}}, {{{}filterArg{}}}, {{{}distinctKeys{}}}, and 
> {{{}collation{}}}.
> see relative discussion in CALCITE-5740



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to