[
https://issues.apache.org/jira/browse/CALCITE-7425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18062345#comment-18062345
]
Zhen Wang commented on CALCITE-7425:
------------------------------------
> A bug without a test case isn't really a bug. Because it's rather subjective
> what a method *should* do if it is never called.
If this method is never used and it has some ambiguity, should we throw an
unsupported exception directly for the SqlBetweenOperator#not method?
> I see that {{RelBuilder.call()}} calls not() for LIKE and SIMILAR operators
> but not for BETWEEN. Maybe there's an opportunity to make {{RelBuilder}} a
> bit smarter.
SqlBetweenOperator is not a valid rex operator, so we may not be able to use it
on toRel.
[https://github.com/apache/calcite/blob/7654dd82162508231cb3ed44e60fed356e931403/core/src/main/java/org/apache/calcite/sql/fun/SqlBetweenOperator.java#L114-L116]
> The logic of the `SqlBetweenOperator#not` method is incorrect.
> --------------------------------------------------------------
>
> Key: CALCITE-7425
> URL: https://issues.apache.org/jira/browse/CALCITE-7425
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.41.0
> Reporter: Zhen Wang
> Priority: Major
> Labels: pull-request-available
>
> While reading the `SqlBetweenOperator` code, I found that the logic of the
> `SqlBetweenOperator#not` method is incorrect.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
