[ 
https://issues.apache.org/jira/browse/CALCITE-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18088132#comment-18088132
 ] 

Julian Hyde commented on CALCITE-7599:
--------------------------------------

Thanks for the example. Can you move it to the description so that an end-user 
can understand it. Expand k/v to key-value.

Clarify whether you consider {{{}-1{}}}, {{2.3}} , {{{}4.0{}}}, and 
{{5.607e-8}} to be numeric literals.

> Enhance parser to allow numeric literals as values in k/v hints as suggested 
> by documentation
> ---------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-7599
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7599
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.42.0
>            Reporter: Chris Dennis
>            Priority: Minor
>              Labels: pull-request-available
>
> There is a small inconsistency remaining between the reference documentation 
> [https://calcite.apache.org/docs/reference.html#syntax] and the parser 
> syntax. The documentation example shows unquoted numeric literals being used 
> as values in a k/v hint. This isn't reflected in the grammar that follows in 
> the document, the parser grammar itself, or in 
> {{SqlHintsConverterTest#testDocumentationExample}}. I think it should be 
> pretty simple to expand the grammar to support either a string or numeric 
> literal, and to update the test to exactly match the documentation example by 
> not quoting the two numeric constants.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to