[
https://issues.apache.org/jira/browse/CALCITE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18105688#comment-18105688
]
Julian Hyde commented on CALCITE-7725:
--------------------------------------
I recall that several DBMS have xxx_SAFE or xxx_CHECKED operators and they are
not consistent. It's possible that we have those operators enabled in
particular dialects and their semantics are consistent with their home DBMS.
We can't do anything about the name, but we should use comments with standard
terminology, and if possible metadata (e.g. Java annotations) so that we know
of the function meets our definition of "safe".
> Review safety of checked arithmetic operators
> ---------------------------------------------
>
> Key: CALCITE-7725
> URL: https://issues.apache.org/jira/browse/CALCITE-7725
> Project: Calcite
> Issue Type: Task
> Reporter: Ruben Q L
> Assignee: Mihai Budiu
> Priority: Major
> Fix For: 1.43.0
>
>
> At the moment, some checked arithmetic operators (CHECKED_PLUS,
> CHECKED_MINUS, CHECKED_TIMES, CHECKED_MINUS_PREFIX) are part of the
> {{safeOps}} set in {{RexSimplify#SafeRexVisitor}}, i.e. they are considered
> "safe" by {{RexSimplify#isSafeExpression}} .
> To be reviewed if these operations should be considered actually "safe",
> since they can throw at runtime (in case of overflow), similarly to e.g. a
> division by zero, which is considered "unsafe".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
