[
https://issues.apache.org/jira/browse/CALCITE-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CALCITE-7765:
------------------------------------
Labels: pull-request-available (was: )
> Re-enable and update disabled tests in JdbcTest and RelMetadataTest
> -------------------------------------------------------------------
>
> Key: CALCITE-7765
> URL: https://issues.apache.org/jira/browse/CALCITE-7765
> Project: Calcite
> Issue Type: Task
> Reporter: Diveyam Mishra
> Assignee: Diveyam Mishra
> Priority: Trivial
> Labels: pull-request-available
>
> Calcite has several tests marked as disabled. These tests were either left
> disabled after earlier investigations or became outdated because Calcite’s
> optimizer and metadata calculations have changed over time.
> # JdbcTest.testCloneGroupBy2
> This test was disabled in 2014 with the comment: “The test returns expected
> results. Not sure why it is disabled.”
> The test runs a query involving a four-table join and GROUP BY aggregation on
> FOODMART_CLONE. The query now executes successfully and produces the expected
> results without any regressions, so the @Disabled annotation can simply be
> removed.
> # JdbcTest.testCloneGroupBy2Plan
> This test was disabled because the actual execution plan differed from the
> expected plan.
> The query planner has changed since the test was originally written. The
> current version of Calcite produces a more optimized plan that uses a
> semi-join (joinType=[semi]) to remove unnecessary columns from the product
> table. It also folds the filter literal into 1997:SMALLINT.
> Since testCloneGroupBy2 confirms that the query itself still produces the
> correct results, the expected plan is updated to match the current optimizer
> output and the @Disabled annotation is removed.
> # RelMetadataTest.testPercentageOriginalRowsOneFilter
> This test was originally disabled when it was ported from Eigenbase because
> the mock catalog tables did not provide row-count information. As a result,
> getPercentageOriginalRows fell back to the default equality selectivity of
> 0.15.
> If I find any more such test I keep adding them in the comment section
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
