[ 
https://issues.apache.org/jira/browse/CALCITE-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249794#comment-14249794
 ] 

Jesus Camacho Rodriguez commented on CALCITE-461:
-------------------------------------------------

The current status is:
- {{AggregateExpandDistinctAggregatesRule.java}} : {color:green}Pull request 
and committed{color} (CALCITE-510).
- {{AggregateFilterTransposeRule.java}} : {color:green}Pull request{color} 
(CALCITE-532).
- {{AggregateProjectMergeRule.java}} : {color:green}Pull request{color} 
(CALCITE-513).
- {{AggregateProjectPullUpConstantsRule.java}} : I can't figure out the 
extension of this rule for grouping sets. Any tip?
- {{AggregateReduceFunctionsRule.java}} : {color:green}Nothing to change: same 
for simple or grouping sets aggregates.{color}
- {{AggregateRemoveRule.java}} : {color:green}Nothing to change: applicable 
only to simple aggregates. Test added, pull not requested yet{color} 
(CALCITE-503).
- {{AggregateStarTableRule.java}} : Is there an interaction of grouping sets 
with this rule?
- {{AggregateUnionAggregateRule.java}} : {color:green}Nothing to change: 
applicable only to simple aggregates. Test added, pull not requested yet{color} 
(CALCITE-503).
- {{AggregateUnionTransposeRule.java}} : {color:green}Pull request and 
committed{color} (CALCITE-502).
- {{FilterAggregateTransposeRule.java}} : {color:green}Pull request{color} 
(CALCITE-533).


[~julianhyde], what do you think about 
{{AggregateProjectPullUpConstantsRule.java}} and 
{{AggregateStarTableRule.java}}? 

Further, is it possible to review (and if it is OK, commit) the extension to 
{{FilterAggregateTransposeRule.java}} (CALCITE-533)?
I discussed with [~jpullokkaran] about adding additional tests with grouping 
sets to Hive to verify it is triggered and works properly.

> Convert more planner rules to handle grouping sets
> --------------------------------------------------
>
>                 Key: CALCITE-461
>                 URL: https://issues.apache.org/jira/browse/CALCITE-461
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Jesus Camacho Rodriguez
>
> Very few planner rules can handle non-simple Aggregates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to