[ 
https://issues.apache.org/jira/browse/CALCITE-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250285#comment-14250285
 ] 

Vladimir Sitnikov edited comment on CALCITE-539 at 12/17/14 6:41 PM:
---------------------------------------------------------------------

{quote}Could we create it only if it does not exist?{quote}
Yes, this can be done.

Here's the patch. Do you accept such approach?
{noformat}
@@ -162,10 +162,6 @@ limitations under the License.
         </excludes>
       </resource>
       <resource>
-        <directory>src/main/resources/version</directory>
-        <filtering>true</filtering>
-      </resource>
-      <resource>
         <!-- Copy freemarker template and fmpp configuration files of
              Calcite's SQL parser to allow clients to extend parser. -->
         <directory>${basedir}/src/main/codegen</directory>
@@ -174,4 +170,22 @@ limitations under the License.
     </resources>
   </build>
 
+  <profiles>
+    <profile>
+      <id>generate-version-properties</id>
+      <activation>
+        <activeByDefault>false</activeByDefault>
+        
<file><missing>target/classes/org-apache-calcite-jdbc.properties</missing></file>
+      </activation>
+      <build>
+        <resources>
+          <resource>
+            <directory>src/main/resources/version</directory>
+            <filtering>true</filtering>
+          </resource>
+        </resources>
+      </build>
+    </profile>
+  </profiles>
+
 </project>
{noformat}


was (Author: vladimirsitnikov):
{quote}Could we create it only if it does not exist?{quote}
Yes, this can be done.

> Avoid org-apache-calcite-jdbc.properties being regenerated on each compilation
> ------------------------------------------------------------------------------
>
>                 Key: CALCITE-539
>                 URL: https://issues.apache.org/jira/browse/CALCITE-539
>             Project: Calcite
>          Issue Type: Sub-task
>    Affects Versions: 1.0.0-incubating
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>
> org-apache-calcite-jdbc.properties includes 
> {{build.timestamp=$\{build.timestamp\}}} so it is different on each build 
> execution.
> Need to do something with that.
> Does it make sense to convert this file to some generated java source?
> That might allow us to reuse Velocity caching of 
> maven-remote-resource-plugins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to