[
https://issues.apache.org/jira/browse/CALCITE-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306136#comment-14306136
]
Julian Hyde edited comment on CALCITE-586 at 2/4/15 10:42 PM:
--------------------------------------------------------------
I suggest the following:
{code}
/** Creates a Signature. */
public Signature(List<ColumnMetaData> columns,
String sql,
List<AvaticaParameter> parameters,
Map<String, Object> internalParameters,
CursorFactory cursorFactory) {
this.columns = columns;
this.sql = sql;
this.parameters = parameters;
this.internalParameters = internalParameters;
this.cursorFactory = cursorFactory;
assert internalParameters != null;
}
/** Used by Jackson to create a Signature by de-serializing JSON. */
@JsonCreator
public static Signature create(
@JsonProperty("columns") List<ColumnMetaData> columns,
@JsonProperty("sql") String sql,
@JsonProperty("parameters") List<AvaticaParameter> parameters,
@JsonProperty("cursorFactory") CursorFactory cursorFactory) {
return new Signature(columns, sql, parameters,
Collections.<String, Object>emptyMap(), cursorFactory);
}
{code}
It makes it clear which interface is being used to de-serialize JSON.
was (Author: julianhyde):
I suggest the following:
{code}
/** Creates a Signature. */
public Signature(List<ColumnMetaData> columns,
String sql,
List<AvaticaParameter> parameters,
Map<String, Object> internalParameters,
CursorFactory cursorFactory) {
this.columns = columns;
this.sql = sql;
this.parameters = parameters;
this.internalParameters = internalParameters;
this.cursorFactory = cursorFactory;
}
/** Used by Jackson to create a Signature by de-serializing JSON. */
@JsonCreator
public static Signature create(
@JsonProperty("columns") List<ColumnMetaData> columns,
@JsonProperty("sql") String sql,
@JsonProperty("parameters") List<AvaticaParameter> parameters,
@JsonProperty("cursorFactory") CursorFactory cursorFactory) {
return new Signature(columns, sql, parameters,
ImmutableMap.<String, Object>of(), cursorFactory);
}
{code}
It makes it clear which interface is being used to de-serialize JSON.
> Serializing Signature.internalParameters can cause exceptions
> -------------------------------------------------------------
>
> Key: CALCITE-586
> URL: https://issues.apache.org/jira/browse/CALCITE-586
> Project: Calcite
> Issue Type: Bug
> Reporter: Trevor Hartman
> Assignee: Julian Hyde
> Priority: Minor
> Fix For: next
>
>
> Observed exceptions:
> {code}
> java.lang.AssertionError: null
> at
> org.apache.calcite.rel.type.RelDataTypeImpl.getFieldList(RelDataTypeImpl.java:138)
> ~[calcite-core-1.0.0-incubating-SNAPSHOT.jar:1.0.0-incubating-SNAPSHOT]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_25]
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> ~[na:1.8.0_25]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[na:1.8.0_25]
> at java.lang.reflect.Method.invoke(Method.java:483) ~[na:1.8.0_25]
> at
> com.fasterxml.jackson.databind.ser.BeanPropertyWriter.serializeAsField(BeanPropertyWriter.java:466)
> ~[jackson-databind-2.4.2.jar:2.4.2]
> {code}
> And in https://github.com/devth/calcite-map-demo:
> {code}
> java.lang.RuntimeException:
> com.fasterxml.jackson.databind.JsonMappingException: No serializer found for
> class org.apache.calcite.sql.type.SqlTypeExplicitPrecedenceList and no
> properties discovered to create BeanSerializer (to avoid exception, disable
> SerializationConfig.SerializationFeature.FAIL_ON_EMPTY_BEANS) ) (through
> reference chain:
> org.apache.calcite.avatica.remote.ResultSetResponse["signature"]->org.apache.calcite.avatica.Signature["internalParameters"]->java.util.LinkedHashMap["v0stashed"]->com.google.common.collect.RegularImmutableList[0]->org.apache.calcite.rex.RexCall["operands"]->com.google.common.collect.RegularImmutableList[0]->org.apache.calcite.rex.RexInputRef["type"]->org.apache.calcite.sql.type.MapSqlType["keyType"]->org.apache.calcite.sql.type.BasicSqlType["precedenceList"])
> at
> org.apache.calcite.avatica.remote.JsonHandler.handle(JsonHandler.java:61)
> ~[calcite-avatica-1.0.0-incubating.jar:1.0.0-incubating]
> at
> org.apache.calcite.avatica.remote.JsonHandler.apply(JsonHandler.java:46)
> ~[calcite-avatica-1.0.0-incubating.jar:1.0.0-incubating]
> at
> org.apache.calcite.avatica.server.AvaticaHandler.handle(AvaticaHandler.java:47)
> ~[calcite-avatica-server-1.0.0-incubating.jar:1.0.0-incubating]
> {code}
> Pull request:
> https://github.com/apache/incubator-calcite/pull/48
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
