[
https://issues.apache.org/jira/browse/CALCITE-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde closed CALCITE-479.
-------------------------------
Closing now that 1.0.0-incubating has been released.
> Migrate RelNode.getChildExps to RelNode.accept(RexShuttle)
> ----------------------------------------------------------
>
> Key: CALCITE-479
> URL: https://issues.apache.org/jira/browse/CALCITE-479
> Project: Calcite
> Issue Type: Bug
> Affects Versions: 1.0.0-incubating
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Labels: newbie
> Fix For: 1.0.0-incubating
>
>
> > What if we kill RelNode.getChildExps and add RelNode
> > RelNode.accept(RexShuttle shuttle) instead?
> {quote}[~julianhyde]
> +1 That method is very general-purpose. I like it.
> It should respect the immutability of RelNodes and return a new
> RelNode iff there are changes. Most RelNodes, except sub-classes of
> project, filter, join, will just 'return this' right away.
> The shuttle must make only very limited changes. Even changing the
> output type of an expression should not be allowed. We can relax these
> restrictions later, if justified.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
