[
https://issues.apache.org/jira/browse/CALCITE-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537520#comment-14537520
]
Xavier FH Leong commented on CALCITE-712:
-----------------------------------------
Hi, I'd remove the support for setMaxRows for PreparedStatement, and open 2
issues for fetch and prepare (see related link)
Finalize commit:
https://github.com/xhoong/incubator-calcite/commit/2b7edc6406a620c0a25c1c01cd3ec0b6edc5a201
I think all AvaticaStatement should be consistent, and the -1 should only be
internal to Calcite, so that in JdbcMeta, the check for setMaxRows do not need
to apply. And in reality, the limit 0 row will never be set for prepare as in
JDBC due to the fact that 0 represented as unlimited. I think if there's any
need for 0 limit for parseSQL, it should be internal to Calcite. Hence the code
is refactor to behave in such.
> Avatica statement execute return all resultset instead of MaxRows from
> setMaxRows
> ---------------------------------------------------------------------------------
>
> Key: CALCITE-712
> URL: https://issues.apache.org/jira/browse/CALCITE-712
> Project: Calcite
> Issue Type: Bug
> Affects Versions: 1.3.0-incubating
> Reporter: Xavier FH Leong
> Assignee: Julian Hyde
> Labels: avatica
> Fix For: next
>
>
> setMaxRows is supported, but after moving to JdbcMeta, max row was ignore and
> full result set is return instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
