[ 
https://issues.apache.org/jira/browse/CALCITE-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538725#comment-14538725
 ] 

Julian Hyde edited comment on CALCITE-721 at 5/11/15 10:03 PM:
---------------------------------------------------------------

We would welcome a patch or pull request for this, and indeed any issue where 
there is missing documentation where documentation is missing but obvious. Not 
all missing javadoc is obvious, by any means, but in this case, the base class 
has a similar constructor and this constructor calls it, so it is reasonable to 
give the parameters the same javadoc.


was (Author: julianhyde):
We would welcome a patch or pull request for this, and indeed any issue where 
there is missing documentation where documentation is missing but obvious. Not 
all missing is obvious, by any means, but in this case, the base class has a 
similar constructor and this constructor calls it.

> LogicalAggregate public constructor arguments are undocumented
> --------------------------------------------------------------
>
>                 Key: CALCITE-721
>                 URL: https://issues.apache.org/jira/browse/CALCITE-721
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Santiago M. Mola
>            Assignee: Julian Hyde
>            Priority: Trivial
>
> LogicalAggregate constructor arguments traitSet and indicator are 
> undocumented in Javadoc. Documentation is missing in the corresponding 
> factories too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to