[ 
https://issues.apache.org/jira/browse/CALCITE-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545008#comment-14545008
 ] 

Julian Hyde commented on CALCITE-708:
-------------------------------------

It seems to me that Calcite needs to be able to generate a full response to 
getTypeInfo without talking to any of its schemas. (There might not be any 
schemas... and if there are multiple schemas, which one to pick? If the schema 
happens to be a JDBC database, its type system will be distorted as it passes 
through Calcite, so it will look like Calcite's type system.)

Your implementation looks good. I'd have iterated over SqlTypeName, too. I'd 
make RelDataTypeSystem a final field in CalciteMetaImpl.

Your typeInfo(MetaTable) is going to be called once for every table. That is 
going to be unpleasant for large schemas. Do we really need to get type info 
from every source? It is turning into a painful requirement.

> Avatica and Calcite to support DatabaseMetaData getTypeInfo
> -----------------------------------------------------------
>
>                 Key: CALCITE-708
>                 URL: https://issues.apache.org/jira/browse/CALCITE-708
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Xavier FH Leong
>            Assignee: Julian Hyde
>            Priority: Minor
>              Labels: avatica, metadata
>             Fix For: next
>
>
> http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTypeInfo()
>  
> Avatica to call underlying connection database metadata for getTypeInfo to 
> show the database supported type and meta info.
> Calcite to provide the info for the underlying adapter thru SqlTypeName and 
> RelDataType



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to