[ 
https://issues.apache.org/jira/browse/CALCITE-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545051#comment-14545051
 ] 

Xavier FH Leong edited comment on CALCITE-708 at 5/15/15 7:21 AM:
------------------------------------------------------------------

Yes, you are correct, scanning thru all schema is not a good idea. I eliminate 
that and now it depends on the RelDataTypeSystem from the connection 
typeFactory. And only covers the type specify in SqlTypeName thru the loops 
over the Enum.

Underlying Calcite adapters needs to implement the typeSystem to override the 
default values. 

One point thou, overriding it also require the implementor to extend 
CalciteConnectionImpl class *or* override the connection factory to pass in the 
typeFactory with the custom typeSystem.


was (Author: xhoong):
Yes, you are correct, scanning thru all schema is not a good idea. I eliminate 
that and now it depends on the RelDataTypeSystem from the connection 
typeFactory. And only covers the type specify in SqlTypeName thru the loops 
over the Enum.

Underlying Calcite adapters needs to implement the typeSystem to override the 
default values. 

One point thou, overriding it also require the implementor to extend 
CalciteConnectionImpl class

> Avatica and Calcite to support DatabaseMetaData getTypeInfo
> -----------------------------------------------------------
>
>                 Key: CALCITE-708
>                 URL: https://issues.apache.org/jira/browse/CALCITE-708
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Xavier FH Leong
>            Assignee: Julian Hyde
>            Priority: Minor
>              Labels: avatica, metadata
>             Fix For: next
>
>
> http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTypeInfo()
>  
> Avatica to call underlying connection database metadata for getTypeInfo to 
> show the database supported type and meta info.
> Calcite to provide the info for the underlying adapter thru SqlTypeName and 
> RelDataType



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to