[
https://issues.apache.org/jira/browse/CALCITE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621714#comment-14621714
]
Julian Hyde edited comment on CALCITE-783 at 7/10/15 4:44 AM:
--------------------------------------------------------------
Yes, rebase on top of master.
{noformat}
git checkout master
git pull --rebase
git checkout 783-monotonicity
# edit to remove whitespace changes
git commit -a
git rebase -i master
{noformat}
During that last rebase, you can re-order and squash commits. In
particular you can squash the last commit (removing whitespace
changes) into your previous commit that introduced them.
was (Author: julianhyde):
Yes, rebase on top of master.
{noformat}
git checkout master
git pull --rebase
git checkout 783-monotonicity
# edit to remove whitespace changes
git commit -a
git rebase -i master
{noformat}
During that last rebase, you can re-order and squash commits. In
particular you can squash the last commit (removing whitespace
changes) into your previous commit that introduced them.
On Thu, Jul 9, 2015 at 9:03 PM, Milinda Lakmal Pathirage (JIRA)
> Infer collation of Project using monotonicity
> ---------------------------------------------
>
> Key: CALCITE-783
> URL: https://issues.apache.org/jira/browse/CALCITE-783
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Milinda Lakmal Pathirage
> Assignee: Julian Hyde
> Attachments: CALCITE-783-0.patch, CALCITE-783-1.patch
>
>
> Current implementation of RelMdCollation#project doesn't handle function
> expressions and because of that we loose any collation metadata related to
> monotonic expressions which can be useful for generating streaming query
> execution plans involving tumbling windows.
> Following is how current code looks like (RelMdCollation):
> 185: for (Ord<RexNode> project : Ord.zip(projects)) {
> 186: if (project.e instanceof RexInputRef) {
> 187: targets.put(((RexInputRef) project.e).getIndex(), project.i);
> 188: }
> 189: }
> We only handle projects of type RexInputRef. But to support monotonic
> expressions we should laso handle projects of type RexCall.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
