Julian Hyde created CALCITE-839:
-----------------------------------

             Summary: Remove Jackson annotations from POJO classes in Meta
                 Key: CALCITE-839
                 URL: https://issues.apache.org/jira/browse/CALCITE-839
             Project: Calcite
          Issue Type: Bug
          Components: avatica
            Reporter: Julian Hyde
            Assignee: Julian Hyde


The Meta interface contains several POJO classes that represent RPC requests or 
responses. Currently a few of those classes have Jackson annotations such as 
@JsonCreator, @JsonProperty to help Jackson serialize the POJO to JSON and 
de-serialize from JSON to the object.

As [~ndimiduk] pointed out in 
http://mail-archives.apache.org/mod_mbox/incubator-calcite-dev/201503.mbox/%3CCANZa=gvkgd+bkj4+ejmuo6ivhs+okgskg1vwdazcy-zijyy...@mail.gmail.com%3E
 these annotations are a "code smell" and should be removed. It makes it look 
as if Jackson is the only possible transport, which is not the case. We can 
continue to use Jackson as a transport, just specify the mappings elsewhere, 
not as annotations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to