[
https://issues.apache.org/jira/browse/CALCITE-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated CALCITE-840:
-------------------------------
Attachment: CALCITE-840.003.patch
Here's the patch "everyone" has been waiting for -- yes, it's still massive.
Changes over the previous:
* No more embedded JSON in protobuf
* More tests
* Tried to cleanup Javadocs per Julian's earlier comment
Included some manual testing of PQS using the protobuf impl via sqlline with
the same level of success as JSON (e.g. ignoring things like PHOENIX-1972).
I just noticed I need to do something about license headers on protobuf specs
and generated code (I think Accumulo has a script I can lift which wraps the
generation and adds headers and fun stuff).
Because this patch has been lagging along for some time now, I'm leaning
against doing things like pulling off the Jackson annotations prior to saying
"this is ready". I don't see the harm in having both Jackson and Protobuf
imports in one place for some time. We know it's something to address in the
future, but I don't see it as something that must be done before this gets
applied IMO.
> Protobuf transport for Avatica
> ------------------------------
>
> Key: CALCITE-840
> URL: https://issues.apache.org/jira/browse/CALCITE-840
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Julian Hyde
> Assignee: Josh Elser
> Fix For: 1.5.0-incubating
>
> Attachments: CALCITE-840.001.patch, CALCITE-840.002.patch,
> CALCITE-840.003.patch
>
>
> Create a transport for Avatica that uses Protobuf.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
