[
https://issues.apache.org/jira/browse/CALCITE-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744304#comment-14744304
]
Josh Elser commented on CALCITE-840:
------------------------------------
bq. I fixed errors about unused dependencies
Hrm, curious. I wonder why mdep didn't fire errors for me.
Seeing all of the {{\@Override}} changes that you made, is there something I
should be setting in an editor/checkstyle plugin to achieve this or is it just
ad-hoc style I should adopt?
In general, thanks for making all those changes in 9948b1cd57. I'll merge those
into my branch and leave the squashing up to you (whether you preserve the
attribution of your own efforts).
bq. did you intend to remote the Apache headers
Oh, this was not intentional. I will push a fix for that.
bq. As generated files, what should the license of these files be?
AFAIK, they should be treated no differently than hand-written Calcite code,
but that's off the top of my head.
bq. Can you change these methods to this general pattern
Ah, yeah, I forgot to do that short-circuit. I can update the POJOs to do that.
> Protobuf transport for Avatica
> ------------------------------
>
> Key: CALCITE-840
> URL: https://issues.apache.org/jira/browse/CALCITE-840
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Julian Hyde
> Assignee: Josh Elser
> Fix For: 1.5.0-incubating
>
> Attachments: CALCITE-840.001.patch, CALCITE-840.002.patch,
> CALCITE-840.003.patch, CALCITE-840.004.patch
>
>
> Create a transport for Avatica that uses Protobuf.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
