[
https://issues.apache.org/jira/browse/CAMEL-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161503#comment-13161503
]
Aki Yoshida edited comment on CAMEL-4731 at 12/2/11 12:56 PM:
--------------------------------------------------------------
Hi Dan,
the blueprint stuff is handled correctly in camel.
Regarding your second comment, Initially, I also tried to fix it by modifying
CXF's AbstractBeanDefinitionParser's bus attribute handling. But this lead to
another issue that required a larger amount of changes. But I saw your fix and
it looks simpler that I thought.
The fix that I suggested is similar to what the current CXF jaxws endpoint
implementation does to get this wiring working. Another benefit of this camel
based fix is that you can run the fixed camel version against older CXF
versions (so that we can stabilize the camel-cxf's endpoint wiring convention
without dependency to a specific version of CXF).
But as you said, the proper fix should go into CXF and with your fix that you
already made in 2.5.1 and 2.4.5, I can live without this fix in Camel, as long
as the camel-cxf's unit test (of the simple wiring) gets activated with the
corrected cxf version soon to ensure the stability of this wiring convention.
Thanks.
regards, aki
was (Author: ay):
Hi Dan,
the blueprint stuff is handled correctly in camel.
Regarding your second comment, I am not sure if it is straightforward to fix
the issue within CXF. Initially, I also tried to fix it by modifying CXF's
AbstractBeanDefinitionParser's bus attribute handling. But this lead to another
issue that required a larger amount of changes. The complication seems to come
from the fact that the bus attribute is semantically used in two different
contexts (i.e., to reference a specific bus or to define a bus).
The fix that I suggested is similar to what the current CXF jaxws endpoint
implementation does to get this wiring working. Another benefit of this camel
based fix is that you can run the fixed camel version against older CXF
versions (so that we can stabilize the camel-cxf's endpoint wiring convention
without dependency to a specific version of CXF)
Thanks.
regards, aki
> simpler wiring of Camel CXF endpoints to named CXF buses in spring
> ------------------------------------------------------------------
>
> Key: CAMEL-4731
> URL: https://issues.apache.org/jira/browse/CAMEL-4731
> Project: Camel
> Issue Type: Improvement
> Components: camel-cxf
> Affects Versions: 2.8.3
> Reporter: Aki Yoshida
> Assignee: Daniel Kulp
> Priority: Minor
> Fix For: 2.8.4, 2.9.0
>
> Attachments: patch.txt
>
>
> I think the current wiring configuration (used in those camel-cxf tests) for
> wiring CXF endpoints to specific cxf bus instances using spring is cumbersome
> and not appealing. So, I would like to suggest a patch for this problem.
> To start, here is how the the current configuration convention looks like:
> <beans ...>
> <bean id="cxf1" class="org.apache.cxf.bus.extension.ExtensionManagerBus"/>
> <bean id="cxf2" class="org.apache.cxf.bus.extension.ExtensionManagerBus"/>
> <cxfcore:bus bus="cxf1">
> ...
> </cxfcore:bus>
> <cxfcore:bus bus="cxf2">
> ....
> </cxfcore:bus>
> <cxf:cxfEndpoint id="routerEndpoint"
> serviceClass="..."
> ...
> bus="cxf1"/>
> <cxf:cxfEndpoint id="serviceEndpoint"
> serviceClass="..."
> ...
> bus="cxf2"/>
> </beans>
> I would like to get rid of the indirect wiring of the CXF endpoints using
> ExtensionManagerBus beans. The attached patch for camel/trunk should directly
> wire the endpoints to the named buses. I would appreciate if you can look at
> it.
> Thank you.
> regards, aki
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
