[
https://issues.apache.org/jira/browse/CAMEL-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179026#comment-13179026
]
Daniel Gredler commented on CAMEL-4779:
---------------------------------------
FYI, I'm just waiting for the 2.9 release to be finalized before picking this
up again. It looks like it's about ready?
Regarding the file renames, how do you want to approach it?
(a) I attach a normal patch like before (keeps SVN history for moved files), or
(b) you move the files in SVN trunk from your end and then I can send a feature
patch that takes advantage of the new class location, without any file moves in
the patch (also would keep SVN history for moved files), or
(c) I attach a partial patch not including the moved files and attach the moved
files separately (I don't think this would keep the SVN history for the moved
files)
What do you think?
> Make Ant path matching in file / FTP component easier to use
> ------------------------------------------------------------
>
> Key: CAMEL-4779
> URL: https://issues.apache.org/jira/browse/CAMEL-4779
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, camel-spring
> Affects Versions: 2.8.3
> Reporter: Daniel Gredler
> Priority: Minor
> Fix For: 2.9.1
>
> Attachments: ant-path-filter.patch
>
>
> The existing codebase has an implicit optional dependency from camel-core to
> camel-spring; camel-core contains the class AntPathMatcherGenericFileFilter,
> which internally uses camel-spring's SpringAntPathMatcherFileFilter class via
> runtime classpath checks and reflection. The reason that
> SpringAntPathMatcherFileFilter is in camel-spring is that it uses Spring's
> AntPathMatcher class internally. Interestingly, there is already an
> AntPathMatcher class with an API very similar to Spring's class in the
> camel-core-xml module.
> This patch moves camel-core-xml's AntPathMatcher into camel-core, removes the
> classpath and reflection magic in camel-core's
> AntPathMatcherGenericFileFilter class, and adds a new class to camel-core
> named GenericFileFilterConverter, which automagically converts strings to ant
> path file filters. The patch also adds some unit tests.
> The end result is that Camel users can now use ant path matching with the
> file and FTP components without having to add a dependency on camel-spring,
> and Camel users can specify the ant path expression to use directly in the
> component querystring, rather than having to go through the work of
> registering an additional file filter instance in the registry (although this
> is only true when the user only needs to specify a single include path, which
> is a very common use case). For example:
> from("file://target/blah?recursive=true&filter=**/*.txt")
> .to(...);
> Instead of:
> from("file://target/blah?recursive=true&filter=#myTxtFilter")
> .to(...);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
