[ 
https://issues.apache.org/jira/browse/CAMEL-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179653#comment-13179653
 ] 

Claus Ibsen commented on CAMEL-4809:
------------------------------------

Thanks Raul for the 2nd patch.

I have thought whether it would be worthwhile to create a 
WhenInterceptSendToEndpointDefinition which extends WhenDefinition, and then 
delegate the filter predicate, to have it copy the FILTER_MATCHED result to 
another property. Kinda like what you do. But without adding that extra set 
property definition. Then we avoid adding that extra step in the route model, 
which gets visible for tooling and whatnot, at runtime.

 
                
> interceptSendToEndpoint with predicate and skip
> -----------------------------------------------
>
>                 Key: CAMEL-4809
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4809
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core, camel-spring
>            Reporter: Raul Kripalani
>            Assignee: Claus Ibsen
>         Attachments: interceptSendToEndpointConditionalSkip.diff, 
> interceptSendToEndpointConditionalSkip_v2.diff, test-interceptor.xml
>
>
> The <when> clause in the interceptors behave like filters. This is okay with 
> intercept and interceptFrom, where the only possible route manipulation is 
> <stop />, which is expressed inside the routing block.
> However, with interceptSendToEndpoint there is one edge case that could cause 
> ambiguity. When skipSendToEndpoint=true, along with a <when> clause, the user 
> might expect that the skipping will only occur if the condition is met. 
> However, it occurs always. The <when /> only determines whether the routing 
> logic contained inside the body of the intercept block will occur or not.
> I propose to add a new attribute onlySkipWhenConditionMet, so that when this 
> is true, the <when> clause will be evaluated to determine if the originally 
> intended endpoint is actually skipped or not.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to