[
https://issues.apache.org/jira/browse/CAMEL-4899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187745#comment-13187745
]
Babak Vahdat commented on CAMEL-4899:
-------------------------------------
@Claus currently almost all osgi blueprint tests fail on my box *WITHOUT EVEN
APPLYING THE PATCH*, however currently I'm behind a HTTP-Proxy so maybe that's
the reason (check the stacktrace below for this).
Do you mind to run these tests on your box to verify the regression? Otherwise
I'll take this over for tonight.
BTW the attached patch overally intends to "remove the unused", so if an
OSGi-lookup should have the side effect for a test to pass then IMHO this
Lookup-API is really odd. However this's my own opinion & problem ;-)
{code}
-------------------------------------------------------------------------------
Test set: org.apache.camel.itest.osgi.bean.validator.BeanValidatorTest
-------------------------------------------------------------------------------
Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 7.437 sec <<<
FAILURE!
testBeanValidatorRoute(org.apache.camel.itest.osgi.bean.validator.BeanValidatorTest)
Time elapsed: 5.156 sec <<< ERROR!
java.lang.RuntimeException: URL
[mvn:org.apache.felix/org.apache.felix.main/3.0.6] could not be resolved.
at
org.ops4j.pax.url.mvn.internal.Connection.getInputStream(Connection.java:195)
at
org.ops4j.pax.url.mvn.internal.AetherBridgeConnection.getInputStream(AetherBridgeConnection.java:68)
at java.net.URL.openStream(URL.java:1010)
at
org.ops4j.pax.runner.platform.internal.StreamUtils.streamCopy(StreamUtils.java:105)
at
org.ops4j.pax.runner.platform.internal.PlatformImpl.download(PlatformImpl.java:642)
at
org.ops4j.pax.runner.platform.internal.PlatformImpl.downloadSystemFile(PlatformImpl.java:509)
at
org.ops4j.pax.runner.platform.internal.PlatformImpl.start(PlatformImpl.java:156)
at org.ops4j.pax.runner.Run.startPlatform(Run.java:683)
at org.ops4j.pax.runner.Run.start(Run.java:226)
at org.ops4j.pax.runner.Run.start(Run.java:182)
at
org.ops4j.pax.exam.container.def.internal.PaxRunnerTestContainer.start(PaxRunnerTestContainer.java:282)
at
org.ops4j.pax.exam.junit.internal.JUnit4TestMethod.invoke(JUnit4TestMethod.java:142)
at
org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:105)
at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:86)
at
org.ops4j.pax.exam.junit.internal.JUnit4MethodRoadie.runBeforesThenTestThenAfters(JUnit4MethodRoadie.java:60)
at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:84)
at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:49)
at
org.ops4j.pax.exam.junit.JUnit4TestRunner.invokeTestMethod(JUnit4TestRunner.java:246)
at
org.ops4j.pax.exam.junit.JUnit4TestRunner.runMethods(JUnit4TestRunner.java:196)
at
org.ops4j.pax.exam.junit.JUnit4TestRunner$2.run(JUnit4TestRunner.java:186)
at
org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:34)
at
org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:44)
at
org.ops4j.pax.exam.junit.JUnit4TestRunner.run(JUnit4TestRunner.java:182)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:119)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:101)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103)
at $Proxy0.invoke(Unknown Source)
at
org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150)
at
org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:74)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69)
validateShouldSuccessWithExpliciteDefaultGroup(org.apache.camel.itest.osgi.bean.validator.BeanValidatorTest)
Time elapsed: 2.047 sec <<< ERROR!
java.lang.RuntimeException: URL
[mvn:org.apache.felix/org.apache.felix.main/3.0.6] could not be resolved.
at
org.ops4j.pax.url.mvn.internal.Connection.getInputStream(Connection.java:195)
at
org.ops4j.pax.url.mvn.internal.AetherBridgeConnection.getInputStream(AetherBridgeConnection.java:68)
at java.net.URL.openStream(URL.java:1010)
at
org.ops4j.pax.runner.platform.internal.StreamUtils.streamCopy(StreamUtils.java:105)
at
org.ops4j.pax.runner.platform.internal.PlatformImpl.download(PlatformImpl.java:642)
at
org.ops4j.pax.runner.platform.internal.PlatformImpl.downloadSystemFile(PlatformImpl.java:509)
at
org.ops4j.pax.runner.platform.internal.PlatformImpl.start(PlatformImpl.java:156)
at org.ops4j.pax.runner.Run.startPlatform(Run.java:683)
at org.ops4j.pax.runner.Run.start(Run.java:226)
at org.ops4j.pax.runner.Run.start(Run.java:182)
at
org.ops4j.pax.exam.container.def.internal.PaxRunnerTestContainer.start(PaxRunnerTestContainer.java:282)
at
org.ops4j.pax.exam.junit.internal.JUnit4TestMethod.invoke(JUnit4TestMethod.java:142)
at
org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:105)
at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:86)
at
org.ops4j.pax.exam.junit.internal.JUnit4MethodRoadie.runBeforesThenTestThenAfters(JUnit4MethodRoadie.java:60)
at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:84)
at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:49)
at
org.ops4j.pax.exam.junit.JUnit4TestRunner.invokeTestMethod(JUnit4TestRunner.java:246)
at
org.ops4j.pax.exam.junit.JUnit4TestRunner.runMethods(JUnit4TestRunner.java:196)
at
org.ops4j.pax.exam.junit.JUnit4TestRunner$2.run(JUnit4TestRunner.java:186)
at
org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:34)
at
org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:44)
at
org.ops4j.pax.exam.junit.JUnit4TestRunner.run(JUnit4TestRunner.java:182)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:119)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:101)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103)
at $Proxy0.invoke(Unknown Source)
at
org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150)
at
org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:74)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69)
{code}
> Code Clean-Up (continued)
> -------------------------
>
> Key: CAMEL-4899
> URL: https://issues.apache.org/jira/browse/CAMEL-4899
> Project: Camel
> Issue Type: Improvement
> Affects Versions: 2.8.3
> Reporter: Babak Vahdat
> Assignee: Babak Vahdat
> Fix For: 2.10.0
>
> Attachments: CAMEL-4899-remove-unused.patch
>
>
> As Hadrian has already proposed by CAMEL-4796 this ticket has been created as
> it's continuation. The remaing tasks are therewith
> - Removal of unused private memebers: Types, Constructors, Fields and Methods
> where applicable
> - Remove the trailing whitespace on all lines, even on the empty ones
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
