[ 
https://issues.apache.org/jira/browse/CAMEL-5398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401332#comment-13401332
 ] 

Henryk Konsek commented on CAMEL-5398:
--------------------------------------

Actually executing the loop below:

for(int i = 0; i < 1000000; i++) {
  Pattern.compile(RandomStringUtils.randomAlphabetic(100));
}

...takes ~10 seconds.

I've never benchmarked the famous Pattern.compile() efficiency but If I can 
parse million of random 100-character long alphanumeric patterns in 10 seconds 
(on my 700$ laptop), then I screw Pattern precompilation for the rest of my 
life :) .
                
> Optimize String.replaceAll() to cache Patterns where suitable
> -------------------------------------------------------------
>
>                 Key: CAMEL-5398
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5398
>             Project: Camel
>          Issue Type: Improvement
>            Reporter: Henryk Konsek
>            Assignee: Henryk Konsek
>             Fix For: 2.11
>
>
> Inspired by issue [1] regarding performance of JMS headers, I performed a 
> little search in IDE and found out that there's pretty much not optimized 
> String.replaceAll() calls.
> I think it will be good to search the code base for such calls again and 
> replace them with references to the static pre-compiled 
> java.util.regex.Patterns. Of course if such action makes sense (like in 
> StringHelper#removeQuotes()).
> [1] https://issues.apache.org/jira/browse/CAMEL-5396

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to