[ 
https://issues.apache.org/jira/browse/CAMEL-5530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claudio Corsi updated CAMEL-5530:
---------------------------------

    Attachment: hbase-updates.diffs

Here is the patch that contains my suggested changes.
                
> Suggestion to replace HBaseContants class with HBaseConstants interface and 
> other minor changes.
> ------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-5530
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5530
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-hbase
>    Affects Versions: 2.10.0
>         Environment: All
>            Reporter: Claudio Corsi
>            Priority: Minor
>              Labels: camel-hbase
>             Fix For: 2.10.1, 2.11.0
>
>         Attachments: hbase-updates.diffs
>
>
> I was looking at the code and noticed that the HBaseContant class can be an 
> interface since all of the defined fields can be set within an interface.
> I am still trying to understand why the class was called HBaseContant instead 
> of something like HBaseConstants.  
> There are also minors changes that I made that made the code a little 
> consistent with my prior fix with respect to tablePool.getTable call.
> I will include a patch that you can take a look at and decide if these 
> changes are useful or not.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to