[
https://issues.apache.org/jira/browse/CAMEL-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558925#comment-13558925
]
Babak Vahdat commented on CAMEL-5983:
-------------------------------------
O.K. already fixed bunch of the tests being attached to this ticket (see
{{CAMEL-5983-partial.patch}}). Following the list of the ones which still need
to be fixed:
{code}
CxfEndpointUtilsTest
JettyHttpProducerSimulate404ErrorTest
MixedPropagationTransactedTest
TransactionalClientDataSourceMixedTransactedTest
ObjectPoolTest
{code}
Hope to find a free time slot by the next days to fix them as well.
> Avoid the negative-tests to behave as false-positive
> ----------------------------------------------------
>
> Key: CAMEL-5983
> URL: https://issues.apache.org/jira/browse/CAMEL-5983
> Project: Camel
> Issue Type: Task
> Components: tests
> Affects Versions: 2.10.3
> Reporter: Babak Vahdat
> Attachments: CAMEL-5983-partial.patch
>
>
> We've got bunch of (negative) tests on the current codebase expecting a
> thrown {{XYZException}} however they don't realize if the expected exception
> is *not* thrown, the typical pattern for this is:
> {code}
> try {
> doSomething_With_Expectation_Of_A_Thrown_XYZException();
> } catch (XYZException e) {
> // expected
> }
> {code}
> Which correctly should be:
> {code}
> try {
> doSomething_With_Expectation_Of_A_Thrown_XYZException();
> fail("Should have thrown an exception");
> } catch (XYZException e) {
> // expected
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
