[
https://issues.apache.org/jira/browse/CAMEL-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561602#comment-13561602
]
Aki Yoshida commented on CAMEL-5574:
------------------------------------
Hi Claus,
As I commented in CAMEL-5989, it looks like the original patch made in 2.10.2
worked for unix and windows as jsch consistently used the absolute path with
"/" as delimiter and FileUtils.compactPath was not converting this path into
the windows syntax on windows.
FileUtils.compachPath in 2.10.3 converted this path into the windows syntax on
windows. And rev 1424437 changed SFTPOperations to call FileUtils.compactPath
with the explicit delimiter.
To unify the processing in ftp and sftp, which have different behaviors, we
need to make some of these underlining assumption detectable or if not,
additionally configurable. Do you think it makes sense to use this ticket to do
this refactoring or create a new one and refer to this ticket?
How do you think?
Thanks.
regards, aki
> camel-sftp's stepwise behavior to walk up and down relatively to avoid
> potential traversal issues
> -------------------------------------------------------------------------------------------------
>
> Key: CAMEL-5574
> URL: https://issues.apache.org/jira/browse/CAMEL-5574
> Project: Camel
> Issue Type: Bug
> Components: camel-ftp
> Affects Versions: 2.10.1
> Reporter: Aki Yoshida
> Assignee: Willem Jiang
> Fix For: 2.9.4, 2.10.2, 2.11.0
>
> Attachments: trunk-camel-ftp.diff
>
>
> I am having a directory traversal problem using the stepwise mode of
> camel-sftp at the producer side. Basically, it can walk down the path from
> the starting directory to the walking directory, but it cannot go back
> correctly to the original starting directly. The server is SSH-2.0-Cleo
> VLProxy/3.0.1 SSH FTP server.
> I saw a related JIRA issue CAMEL-3309 that describes some issues in the
> stepwise traversal and some background to this related problem.
> My question is on the part that changes the working directory back to the
> original starting folder. I am wondering why we are using stepwise traversal
> from the ancestor directory towards the starting child directory, instead of
> moving upwards relatively from the working directory back to the starting
> directory. This reverse traversal does not require accessing the ancestry
> path above the staring directory (hence, not affected by the accessing
> problem). And in fact, I think this reverse stepwise traversal seems more
> natural order than doing stepwise traversal each time from top down. How do
> you think?
> I have made a change that implements this reverse stepwise traversal in
> SftpOperations and also made a few minor improvement changes.
> This changed version passes all the existing tests and works also against the
> above server.
> I am attaching a patch file for this change. I would appreciate if you can
> comment on it.
> Thanks.
> regards, aki
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
