[
https://issues.apache.org/jira/browse/CAMEL-5880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588108#comment-13588108
]
Babak Vahdat commented on CAMEL-5880:
-------------------------------------
Applying the provided patch on trunk causes regression by
{{QuickfixjConsumerTest}} and {{QuickfixjProducerTest}}:
{code}
~/dev/workspace/camel/components/camel-quickfix>svn st
M
src/test/java/org/apache/camel/component/quickfixj/examples/RequestReplyExample.java
M src/main/java/org/apache/camel/component/quickfixj/MessagePredicate.java
M
src/main/java/org/apache/camel/component/quickfixj/converter/QuickfixjConverters.java
M
src/main/java/org/apache/camel/component/quickfixj/QuickfixjConsumer.java
M
src/main/java/org/apache/camel/component/quickfixj/QuickfixjEndpoint.java
~/dev/workspace/camel/components/camel-quickfix>mvn test
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Camel :: QuickFIX/J 2.11-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-bundle-plugin:2.3.7:cleanVersions (versions) @ camel-quickfix
---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.4:process (default) @ camel-quickfix
---
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
camel-quickfix ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @
camel-quickfix ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] >>> camel-package-maven-plugin:2.11-SNAPSHOT:package (default) @
camel-quickfix >>>
[INFO]
[INFO] --- maven-bundle-plugin:2.3.7:cleanVersions (versions) @ camel-quickfix
---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.4:process (default) @ camel-quickfix
---
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
camel-quickfix ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @
camel-quickfix ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] <<< camel-package-maven-plugin:2.11-SNAPSHOT:package (default) @
camel-quickfix <<<
[INFO]
[INFO] --- camel-package-maven-plugin:2.11-SNAPSHOT:package (default) @
camel-quickfix ---
[INFO] Generated
/Users/bvahdat/dev/workspace/camel/components/camel-quickfix/target/classes/META-INF/services/org/apache/camel/component.properties
containing the Camel component quickfix
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @
camel-quickfix ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @
camel-quickfix ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:2.13:test (default-test) @ camel-quickfix ---
[INFO] Surefire report directory:
/Users/bvahdat/dev/workspace/camel/components/camel-quickfix/target/surefire-reports
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.camel.component.quickfixj.QuickfixjComponentTest
<20130227-07:36:21, FIX.4.4:FOO->BAR, event> (Session FIX.4.4:FOO->BAR schedule
is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:21, FIX.4.4:FOO->BAR, event> (Created session: FIX.4.4:FOO->BAR)
<20130227-07:36:21, FIX.4.4:FOO->BAR, error> (java.io.IOException:
java.io.IOException: Endpoint unavailable: vm:1234 (Next retry in 30000
milliseconds))
<20130227-07:36:22, FIX.4.4:ACCEPTOR->INITIATOR, event> (Session
FIX.4.4:ACCEPTOR->INITIATOR schedule is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:22, FIX.4.4:ACCEPTOR->INITIATOR, event> (Created session:
FIX.4.4:ACCEPTOR->INITIATOR)
<20130227-07:36:22, FIX.4.4:INITIATOR->ACCEPTOR, event> (Session
FIX.4.4:INITIATOR->ACCEPTOR schedule is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:22, FIX.4.4:INITIATOR->ACCEPTOR, event> (Created session:
FIX.4.4:INITIATOR->ACCEPTOR)
<20130227-07:36:23, FIX.4.4:INITIATOR->ACCEPTOR, outgoing>
(8=FIX.4.49=7235=A34=149=INITIATOR52=20130227-07:36:23.02956=ACCEPTOR98=0108=3010=004)
<20130227-07:36:23, FIX.4.4:ACCEPTOR->INITIATOR, incoming>
(8=FIX.4.49=7235=A34=149=INITIATOR52=20130227-07:36:23.02956=ACCEPTOR98=0108=3010=004)
<20130227-07:36:23, FIX.4.4:ACCEPTOR->INITIATOR, event> (Accepting session
FIX.4.4:ACCEPTOR->INITIATOR from anonymous(121165166))
<20130227-07:36:23, FIX.4.4:ACCEPTOR->INITIATOR, event> (Acceptor heartbeat set
to 30 seconds)
<20130227-07:36:23, FIX.4.4:ACCEPTOR->INITIATOR, event> (Received logon)
<20130227-07:36:23, FIX.4.4:INITIATOR->ACCEPTOR, event> (Initiated logon
request)
<20130227-07:36:23, FIX.4.4:ACCEPTOR->INITIATOR, outgoing>
(8=FIX.4.49=7235=A34=149=ACCEPTOR52=20130227-07:36:23.03856=INITIATOR98=0108=3010=004)
<20130227-07:36:23, FIX.4.4:INITIATOR->ACCEPTOR, incoming>
(8=FIX.4.49=7235=A34=149=ACCEPTOR52=20130227-07:36:23.03856=INITIATOR98=0108=3010=004)
<20130227-07:36:23, FIX.4.4:ACCEPTOR->INITIATOR, event> (Responding to logon
request)
<20130227-07:36:23, FIX.4.4:INITIATOR->ACCEPTOR, event> (Received logon)
<20130227-07:36:23, FIX.4.4:ACCEPTOR->INITIATOR, outgoing>
(8=FIX.4.49=8135=C34=249=ACCEPTOR52=20130227-07:36:23.04456=INITIATOR94=0147=Test164=ID10=166)
<20130227-07:36:23, FIX.4.4:INITIATOR->ACCEPTOR, incoming>
(8=FIX.4.49=8135=C34=249=ACCEPTOR52=20130227-07:36:23.04456=INITIATOR94=0147=Test164=ID10=166)
<20130227-07:36:23, FIX.4.4:ACCEPTOR->INITIATOR, outgoing>
(8=FIX.4.49=8135=C34=349=ACCEPTOR52=20130227-07:36:23.04556=INITIATOR94=0147=Test164=ID10=168)
<20130227-07:36:23, FIX.4.4:INITIATOR->ACCEPTOR, incoming>
(8=FIX.4.49=8135=C34=349=ACCEPTOR52=20130227-07:36:23.04556=INITIATOR94=0147=Test164=ID10=168)
<20130227-07:36:23, FIX.4.4:FOO->BAR, event> (Session FIX.4.4:FOO->BAR schedule
is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:23, FIX.4.4:FOO->BAR, event> (Created session: FIX.4.4:FOO->BAR)
<20130227-07:36:23, FIX.4.4:FOO->BAR, error> (java.io.IOException:
java.io.IOException: Endpoint unavailable: vm:1234 (Next retry in 30000
milliseconds))
<20130227-07:36:23, FIX.4.4:FOO->BAR, event> (Session FIX.4.4:FOO->BAR schedule
is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:23, FIX.4.4:FOO->BAR, event> (Created session: FIX.4.4:FOO->BAR)
<20130227-07:36:23, FIX.4.4:FOO->BAR, error> (java.io.IOException:
java.io.IOException: Endpoint unavailable: vm:1234 (Next retry in 30000
milliseconds))
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.555 sec
Running org.apache.camel.component.quickfixj.QuickfixjConfigurationTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec
Running org.apache.camel.component.quickfixj.QuickfixjConsumerTest
Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.176 sec <<<
FAILURE!
processInOutExchange(org.apache.camel.component.quickfixj.QuickfixjConsumerTest)
Time elapsed: 0.171 sec <<< FAILURE!
org.mockito.exceptions.verification.NeverWantedButInvoked:
exchange.setException(
isA(java.lang.Exception)
);
Never wanted here:
-> at
org.apache.camel.component.quickfixj.QuickfixjConsumerTest.processInOutExchange(QuickfixjConsumerTest.java:134)
But invoked here:
-> at
org.apache.camel.component.quickfixj.QuickfixjConsumerTest.processInOutExchange(QuickfixjConsumerTest.java:133)
at
org.apache.camel.component.quickfixj.QuickfixjConsumerTest.processInOutExchange(QuickfixjConsumerTest.java:134)
setExceptionOnInOutExchange(org.apache.camel.component.quickfixj.QuickfixjConsumerTest)
Time elapsed: 0.003 sec <<< FAILURE!
org.mockito.exceptions.verification.junit.ArgumentsAreDifferent:
Argument(s) are different! Wanted:
exchange.setException(
isA(java.lang.IllegalStateException)
);
-> at
org.apache.camel.component.quickfixj.QuickfixjConsumerTest.setExceptionOnInOutExchange(QuickfixjConsumerTest.java:114)
Actual invocation has different arguments:
exchange.setException(
java.lang.NullPointerException
);
-> at
org.apache.camel.component.quickfixj.QuickfixjConsumer.onExchange(QuickfixjConsumer.java:45)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
at
org.apache.camel.component.quickfixj.QuickfixjConsumerTest.setExceptionOnInOutExchange(QuickfixjConsumerTest.java:114)
Running org.apache.camel.component.quickfixj.QuickfixjConvertersTest
<20130227-07:36:23, FIX.4.4:FOO->BAR, event> (Session FIX.4.4:FOO->BAR schedule
is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:23, FIX.4.4:FOO->BAR, event> (Created session: FIX.4.4:FOO->BAR)
<20130227-07:36:23, FIX.4.4:FOO->BAR, event> (Session FIX.4.4:FOO->BAR schedule
is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:23, FIX.4.4:FOO->BAR, event> (Created session: FIX.4.4:FOO->BAR)
<20130227-07:36:23, FIX.4.4:FOO->BAR, event> (Session FIX.4.4:FOO->BAR schedule
is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:23, FIX.4.4:FOO->BAR, event> (Created session: FIX.4.4:FOO->BAR)
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.628 sec
Running org.apache.camel.component.quickfixj.QuickfixjEngineTest
<20130227-07:36:23, FIX.4.4:FOO->BAR, event> (Session FIX.4.4:FOO->BAR schedule
is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:23, FIX.4.4:FOO->BAR, event> (Created session: FIX.4.4:FOO->BAR)
<20130227-07:36:23, FIX.4.4:FOO->BAR, error> (java.io.IOException:
java.io.IOException: Endpoint unavailable: vm:1234 (Next retry in 30000
milliseconds))
<20130227-07:36:23, FIX.4.2:MARKET->TRADER, event> (Session
FIX.4.2:MARKET->TRADER schedule is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:23, FIX.4.2:MARKET->TRADER, event> (Created session:
FIX.4.2:MARKET->TRADER)
<20130227-07:36:23, FIX.4.2:TRADER->MARKET, event> (Session
FIX.4.2:TRADER->MARKET schedule is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:23, FIX.4.2:TRADER->MARKET, event> (Created session:
FIX.4.2:TRADER->MARKET)
<20130227-07:36:24, FIX.4.2:TRADER->MARKET, outgoing>
(8=FIX.4.29=6835=A34=149=TRADER52=20130227-07:36:24.99056=MARKET98=0108=12010=193)
<20130227-07:36:24, FIX.4.2:MARKET->TRADER, incoming>
(8=FIX.4.29=6835=A34=149=TRADER52=20130227-07:36:24.99056=MARKET98=0108=12010=193)
<20130227-07:36:24, FIX.4.2:MARKET->TRADER, event> (Accepting session
FIX.4.2:MARKET->TRADER from anonymous(1183562193))
<20130227-07:36:24, FIX.4.2:MARKET->TRADER, event> (Acceptor heartbeat set to
120 seconds)
<20130227-07:36:24, FIX.4.2:TRADER->MARKET, event> (Initiated logon request)
<20130227-07:36:24, FIX.4.2:MARKET->TRADER, event> (Received logon)
<20130227-07:36:24, FIX.4.2:MARKET->TRADER, outgoing>
(8=FIX.4.29=6835=A34=149=MARKET52=20130227-07:36:24.99256=TRADER98=0108=12010=195)
<20130227-07:36:24, FIX.4.2:TRADER->MARKET, incoming>
(8=FIX.4.29=6835=A34=149=MARKET52=20130227-07:36:24.99256=TRADER98=0108=12010=195)
<20130227-07:36:24, FIX.4.2:MARKET->TRADER, event> (Responding to logon request)
<20130227-07:36:24, FIX.4.2:TRADER->MARKET, event> (Received logon)
<20130227-07:36:24, FIX.4.2:TRADER->MARKET, outgoing>
(8=FIX.4.29=9235=C34=249=TRADER52=20130227-07:36:24.99456=MARKET94=0147=Test164=ID33=158=Content10=146)
<20130227-07:36:24, FIX.4.2:MARKET->TRADER, incoming>
(8=FIX.4.29=9235=C34=249=TRADER52=20130227-07:36:24.99456=MARKET94=0147=Test164=ID33=158=Content10=146)
<20130227-07:36:25, FIX.4.4:FOO->BAR, event> (Session FIX.4.4:FOO->BAR schedule
is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:25, FIX.4.4:FOO->BAR, event> (Created session: FIX.4.4:FOO->BAR)
Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.074 sec
Running org.apache.camel.component.quickfixj.QuickfixjProducerTest
Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.048 sec <<<
FAILURE!
processInOutExchangeSuccess(org.apache.camel.component.quickfixj.QuickfixjProducerTest)
Time elapsed: 5.036 sec <<< FAILURE!
org.mockito.exceptions.verification.WantedButNotInvoked:
Wanted but not invoked:
message.setBody(
8=FIX.4.29=2535=C49=TARGET56=SENDER10=194
);
-> at
org.apache.camel.component.quickfixj.QuickfixjProducerTest.processInOutExchangeSuccess(QuickfixjProducerTest.java:155)
Actually, there were zero interactions with this mock.
at
org.apache.camel.component.quickfixj.QuickfixjProducerTest.processInOutExchangeSuccess(QuickfixjProducerTest.java:155)
Running org.apache.camel.component.quickfixj.QuickfixjSpringTest
<20130227-07:36:30, FIX.4.2:ACCEPTOR->INITIATOR, event> (Session
FIX.4.2:ACCEPTOR->INITIATOR schedule is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:30, FIX.4.2:ACCEPTOR->INITIATOR, event> (Created session:
FIX.4.2:ACCEPTOR->INITIATOR)
<20130227-07:36:30, FIX.4.2:INITIATOR->ACCEPTOR, event> (Session
FIX.4.2:INITIATOR->ACCEPTOR schedule is daily, 00:00:00-UTC - 00:00:00-UTC)
<20130227-07:36:30, FIX.4.2:INITIATOR->ACCEPTOR, event> (Created session:
FIX.4.2:INITIATOR->ACCEPTOR)
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.727 sec
Results :
Failed tests:
QuickfixjConsumerTest.processInOutExchange:134
exchange.setException(
isA(java.lang.Exception)
);
Never wanted here:
-> at
org.apache.camel.component.quickfixj.QuickfixjConsumerTest.processInOutExchange(QuickfixjConsumerTest.java:134)
But invoked here:
-> at
org.apache.camel.component.quickfixj.QuickfixjConsumerTest.processInOutExchange(QuickfixjConsumerTest.java:133)
QuickfixjConsumerTest.setExceptionOnInOutExchange:114
Argument(s) are different! Wanted:
exchange.setException(
isA(java.lang.IllegalStateException)
);
-> at
org.apache.camel.component.quickfixj.QuickfixjConsumerTest.setExceptionOnInOutExchange(QuickfixjConsumerTest.java:114)
Actual invocation has different arguments:
exchange.setException(
java.lang.NullPointerException
);
-> at
org.apache.camel.component.quickfixj.QuickfixjConsumer.onExchange(QuickfixjConsumer.java:45)
QuickfixjProducerTest.processInOutExchangeSuccess:155
Wanted but not invoked:
message.setBody(
8=FIX.4.29=2535=C49=TARGET56=SENDER10=194
);
-> at
org.apache.camel.component.quickfixj.QuickfixjProducerTest.processInOutExchangeSuccess(QuickfixjProducerTest.java:155)
Actually, there were zero interactions with this mock.
Tests run: 42, Failures: 3, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12.834s
[INFO] Finished at: Wed Feb 27 08:36:30 CET 2013
[INFO] Final Memory: 13M/1011M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.13:test (default-test) on
project camel-quickfix: There are test failures.
[ERROR]
[ERROR] Please refer to
/Users/bvahdat/dev/workspace/camel/components/camel-quickfix/target/surefire-reports
for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
{code}
> camel-quickfix: QuickfixjEndpoint should adhere the InOut exchange pattern if
> you would ask for this MEP
> --------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-5880
> URL: https://issues.apache.org/jira/browse/CAMEL-5880
> Project: Camel
> Issue Type: Bug
> Components: camel-quickfix
> Affects Versions: 2.10.3
> Reporter: Babak Vahdat
> Priority: Minor
> Attachments: requestreply.patch
>
>
> See
> http://camel.465427.n5.nabble.com/camel-quickfix-RequestReplyExample-java-io-IOException-td5723769.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
