[
https://issues.apache.org/jira/browse/CAMEL-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595712#comment-13595712
]
Ioannis Alexandrakis commented on CAMEL-6116:
---------------------------------------------
This would be a nice solution, and you may change it so, if you like (or I
could do it, I don't know how this works).
However, my main thinking was that even though camel-smpp returns Byte, Integer
etc, it does this as a separate header in the SmppMessage. So whoever uses
those headers, already knows which types they are (e.g. in the documentation
the CamelSmppSourceAddrTon is byte and so on). In the optional parameters'
case, I created a Map with arbitrary names inside (whatever jsmpp spits out, so
whoever wanted to use them would have to know the jsmpp return types for those
optional parameters beforehand). So, for simplicity (and testing, to overview
them in the log as strings and not have to modify them), I just created them as
a Map<String, String>.
> Populate all optional parameters from DeliverSm (if it is DeliveryReceipt)
> --------------------------------------------------------------------------
>
> Key: CAMEL-6116
> URL: https://issues.apache.org/jira/browse/CAMEL-6116
> Project: Camel
> Issue Type: Improvement
> Components: camel-smpp
> Reporter: Ioannis Alexandrakis
> Assignee: Christian Müller
> Labels: optional, parameters
> Fix For: 2.11.0
>
> Attachments: enableOptParamsOnReceipts.java.patch,
> enableOptParamsOnReceiptsv2.java.patch
>
>
> Hello all,
> I am currently working on a project requiring the use of camel-smpp. I
> stumbled upon some problems integrating with the customer's SMSC, and I
> modified the code of camel-smpp in order to fit my needs (just adding some
> functionality though, not removing any).
> More specifically, for submitting a new message, the delivery receipt held
> the corresponding submit_sm id in the optional parameters (as
> receipted_message_id). With the current trunk code, I did not get the
> optional parameters of the delivery receipt, so I could not match the
> delivery receipt to the outgoing sms. As a solution I just looped all the
> optional parameters and put them into a map as a header (and instead of
> checking each optional parameter name, I just put whatever jsmpp was sending
> back, so if someone wants to put other optional parameters to jsmpp too, they
> would simply automatically be populated back in camel-smpp.)
> Please find the patch attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
